You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
order_cycle_distributed_products.rb is assuming that products can have no variants and that master variants can be added to OCs. These assumptions are incorrect and we should update the code to reflect these facts:
there should be no products without variants
there should be no master variants in order cycles
We need to clear the code and the data if applicable.
Additionally, there may be other parts of the code that would also benefit from being reviewed in terms of these assumptions.
What we should change and why (this is tech debt)
order_cycle_distributed_products.rb is assuming that products can have no variants and that master variants can be added to OCs. These assumptions are incorrect and we should update the code to reflect these facts:
We need to clear the code and the data if applicable.
Additionally, there may be other parts of the code that would also benefit from being reviewed in terms of these assumptions.
Context
Raised as part of #3581
The text was updated successfully, but these errors were encountered: