Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve order_cycle_distributed_products #3596

Open
luisramos0 opened this issue Mar 12, 2019 · 0 comments
Open

Improve order_cycle_distributed_products #3596

luisramos0 opened this issue Mar 12, 2019 · 0 comments

Comments

@luisramos0
Copy link
Contributor

What we should change and why (this is tech debt)

order_cycle_distributed_products.rb is assuming that products can have no variants and that master variants can be added to OCs. These assumptions are incorrect and we should update the code to reflect these facts:

  • there should be no products without variants
  • there should be no master variants in order cycles
    We need to clear the code and the data if applicable.

Additionally, there may be other parts of the code that would also benefit from being reviewed in terms of these assumptions.

Context

Raised as part of #3581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things
Development

No branches or pull requests

1 participant