Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload Orders page after payment is captured #4377

Closed
kirstenalarsen opened this issue Oct 17, 2019 · 4 comments · Fixed by #4580
Closed

Don't reload Orders page after payment is captured #4377

kirstenalarsen opened this issue Oct 17, 2019 · 4 comments · Fixed by #4580
Assignees
Labels
AU Selected to be done by the Australian active instance enhancement improvement good first issue hackathon Issues for upcoming hackathons

Comments

@kirstenalarsen
Copy link
Contributor

kirstenalarsen commented Oct 17, 2019

Description

Acceptance Criteria & Tests

Enterprise user should be able to set filters on the orders page to select a group of orders, and then 'capture payments' on these without losing their filter selection and being returned to home orders page each time

Create multiple orders with cash payments i.e. order is complete but not paid. Orders that are complete but not paid have a small tick at the right hand side which allows the payment to be captured

image.png

Set filters to select the orders you are looking for e.g. all orders from a particular user, order cycle or distributor etc

image.png

Hit capture payment button on the first order
image.png

Page SHOULD NOT reload to Orders page with no filters selected.

The capture payment action should take place while keeping the same selection of filters on the page. So the page should then look like this

image.png

[This should NOT happen]
image.png

@kirstenalarsen kirstenalarsen added good first issue hackathon Issues for upcoming hackathons enhancement improvement labels Oct 17, 2019
@kirstenalarsen kirstenalarsen added the AU Selected to be done by the Australian active instance label Nov 8, 2019
@kirstenalarsen kirstenalarsen reopened this Nov 8, 2019
@Matt-Yorkley Matt-Yorkley self-assigned this Dec 13, 2019
@Matt-Yorkley
Copy link
Contributor

I'm taking a look at this now. The logic and UX is identical for both the capture and ship buttons. I think it makes sense to update both at the same time here.

@Matt-Yorkley
Copy link
Contributor

Ok, this is going to need some UX work as well. Currently when we refresh the page we can give feedback via the green/red flash messages in the header. If we move to asynchronous requests, we'll need to introduce a new way of delivering success/error feedback on this page.

@RachL ?

@RachL
Copy link
Contributor

RachL commented Dec 13, 2019

@Matt-Yorkley when you capture a payment the button changes to a ship button, so it should give users a hint. But maybe we can play more with the button? Turn it green or red if there is an error?
Although I'm not sure we see the button currently in case of an error...we just have no button at all...
Can a message be displayed even though we don't reload the page?

@Matt-Yorkley
Copy link
Contributor

I don't think we can reuse the message in the header. I'll take a look tomorrow.

In most cases it should save correctly. I don't think an error will be common. I'm thinking of trying a small spinning icon next to the button (floating to the right) when loading, then a small green tick or red cross that fades after a couple of seconds..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AU Selected to be done by the Australian active instance enhancement improvement good first issue hackathon Issues for upcoming hackathons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants