Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "select all" on incoming exchanges to a server call #4487

Open
Tracked by #4610
luisramos0 opened this issue Nov 24, 2019 · 0 comments
Open
Tracked by #4610

Move "select all" on incoming exchanges to a server call #4487

luisramos0 opened this issue Nov 24, 2019 · 0 comments

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Nov 24, 2019

What we should change and why (this is tech debt)

We can now avoid having to load all products to the browser in most situations by making the select all button call the server instead of loading all products and then select them all.

Context

This is a natural improvement after #4476, this was not done as part of #4471 to keep that PR small.

Impact and timeline

This will have a massive impact when handling very large OCs. With this change, we can probably load the incoming exchange, select all products and save in under 1 minute even for a 10k products exchange.

@sigmundpetersen sigmundpetersen changed the title OC performance - move "select all" on incoming exchanges to a server call Move "select all" on incoming exchanges to a server call May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things 💤
Development

No branches or pull requests

1 participant