Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC performance - move "select all" on outgoing exchanges to a server call #4488

Open
Tracked by #4610
luisramos0 opened this issue Nov 24, 2019 · 0 comments
Open
Tracked by #4610

Comments

@luisramos0
Copy link
Contributor

What we should change and why (this is tech debt)

We should make "select all" in outgoing exchanges a server call so that the outgoing exchanges page doesnt need to load all variants that are part of all incoming exchanges.
I think this is required before #4480 is done because visible_variants_for_outgoing_exchan is required for the select all process in the outgoing exchanges.

Context

This comes from #4471

Impact and timeline

This will have a big impact when handling very large OCs. With this change, we can probably load the outgoing exchange, select all products and save in under 1 minute even for a 10k products exchange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things 💤
Development

No branches or pull requests

1 participant