Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ByeBye Spree] Move Payment model to OFN #5689

Closed
luisramos0 opened this issue Jun 27, 2020 · 1 comment · Fixed by #5806
Closed

[ByeBye Spree] Move Payment model to OFN #5689

luisramos0 opened this issue Jun 27, 2020 · 1 comment · Fixed by #5806
Assignees

Comments

@luisramos0
Copy link
Contributor

What we should change and why (this is tech debt)

Move Payment model and processing class to OFN and merge with decorators.

These files:

  • core/app/models/spree/payment.rb MERGE WITH DECORATOR
  • spec/models/spree/payment_spec.rb MERGE WITH OFN VERSION (or ignore)
  • core/app/models/spree/payment/processing.rb COPY

Context

Part of #4826

Impact and timeline

This will enable us to stop working on top of decorators and refactor the Spree code to a better version (our coding standards are better)

@luisramos0
Copy link
Contributor Author

@sauloperez assigned to you as this is already done in your PR #5678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants