Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software version can be displayed in the UI or Admin interface #577

Closed
pmackay opened this issue Jun 1, 2015 · 19 comments · Fixed by #11004
Closed

Software version can be displayed in the UI or Admin interface #577

pmackay opened this issue Jun 1, 2015 · 19 comments · Fixed by #11004
Assignees
Labels
enhancement improvement good first issue hackathon Issues for upcoming hackathons

Comments

@pmackay
Copy link
Contributor

pmackay commented Jun 1, 2015

It would be very helpful for testers if there was an obvious way to know what version of OFN was running when looking at web pages, rather than having to use git versions to work this out.

Would best practice here be to add a VERSION file in the project root, that is updated on each major version update?

@lin-d-hop any thoughts?

@pmackay pmackay added the uk label Jun 1, 2015
@pmackay pmackay added this to the UK Backlog milestone Jun 1, 2015
@pmackay pmackay added the easy label Jul 13, 2015
@elf-pavlik elf-pavlik modified the milestones: EU Hackathon, UK Backlog Dec 12, 2015
@Em-AK
Copy link
Contributor

Em-AK commented Dec 14, 2015

@emaestracci and @knopfler81 implemented this by relying on the last existing git tag.

@pmackay
Copy link
Contributor Author

pmackay commented Dec 14, 2015

@Em-AK is there a commit for that?

@Em-AK
Copy link
Contributor

Em-AK commented Dec 14, 2015

@Em-AK
Copy link
Contributor

Em-AK commented Dec 15, 2015

Update here WildCodeSchool#3

@pmackay
Copy link
Contributor Author

pmackay commented Jan 30, 2016

@Em-AK what's needed to get the PR for this completed?

@bingxie
Copy link
Contributor

bingxie commented Apr 8, 2016

I have used this gem(https://github.com/dtaniwaki/rack-dev-mark) to show different things for different envs. And it's very beautiful.

@bingxie
Copy link
Contributor

bingxie commented Jun 1, 2016

Display the version on two places.

snip20160601_1
snip20160601_2

@daniellemoorhead
Copy link
Contributor

Hey @bingxie have you put this into staging for @sstead to test?

@bingxie
Copy link
Contributor

bingxie commented Jun 8, 2016

Need someone to review the PR, if there is no comments, @sstead can stage it and have a test. Thanks

@daniellemoorhead daniellemoorhead modified the milestones: v1.8.3 - Tres puntos, v1.9 - Enigmatic Edamame! Jul 1, 2016
@daniellemoorhead daniellemoorhead modified the milestones: v1.9 - Enigmatic Edamame!, v1.8.3 - Tres puntos, v1.10 - Funky Feijoa! Jul 15, 2016
@daniellemoorhead daniellemoorhead removed this from the June dot point release milestone Jun 30, 2017
@daniellemoorhead
Copy link
Contributor

Work was done in #1021 but a new approach was discussed on that PR that isn't yet implemented. Would be good to have someone pick this up and implement the described approach:

I really like the idea of using GitHub's webhooks to listen for release events and to then update the version number accordingly.

@sauloperez
Copy link
Contributor

sauloperez commented Sep 20, 2017

Can someone describe that other approach @oeoeaio @mkllnk ?

I really like the idea of using GitHub's webhooks to listen for release events and to then update the version number accordingly.

To me it looks overly complex. What's wrong with having a VERSION file in each deploy and reading the number from it? I know it's not as cool as a webhook :trollface:

@mkllnk
Copy link
Member

mkllnk commented Sep 22, 2017

What's wrong with having a VERSION file in each deploy and reading the number from it?

Do you mean that the deployment process generates that file, but it's not tracked by Git? Sounds simple and it would do the job. Only in Aus production we would never see the tagged version name, because we deploy before we release. Not a big deal for me.

@sauloperez
Copy link
Contributor

exactly that @mkllnk. You get the tag and the sha from the git remote, for instance. @enricostano you're way more familiar with the deployment process than me. Does this sound good?

@oeoeaio
Copy link
Contributor

oeoeaio commented Sep 22, 2017

To me it looks overly complex.

Looking back at what we were proposing, I tend to agree. It would have been shiny, but maintaining webhooks to all servers wouldn't have been very pleasant.

If we are going to update the version as part of deployment it would be good to only have to implement that in one place. @mkllnk, in an ideal world would we use ofn-install for deployment, and encourage everyone else to do the same?

@mkllnk
Copy link
Member

mkllnk commented Oct 4, 2017

To me it looks overly complex.
maintaining webhooks to all servers wouldn't have been very pleasant.

I agree.

it would be good to only have to implement that in one place.

Yes, I agree on that as well.

The whole Ansible vs Git deployment discussion is a bit bigger. I think we should do that at the forum, possible topic: "What would be the best way to deploy and update OFN?"

Just to solve this issue, we could write a little shell script that writes the currently checked out version to a file. We can call that script from the Git hook and the Ansible playbook. Hm, it's actually a one liner:

#!/bin/sh
git describe --tags > VERSION

What do you think?

@lin-d-hop
Copy link
Contributor

@RachL RachL added hackathon Issues for upcoming hackathons enhancement improvement labels Apr 26, 2019
@RachL
Copy link
Contributor

RachL commented Apr 26, 2019

Reopen for the upcoming devhack

@RachL RachL reopened this Apr 26, 2019
@Matt-Yorkley Matt-Yorkley self-assigned this May 4, 2019
@lin-d-hop
Copy link
Contributor

No one devhacked this and we have a workaround using Slack and Github Wiki. Bye bye. #gitcull

@drummer83
Copy link
Contributor

Fixed by #11004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement good first issue hackathon Issues for upcoming hackathons
Projects
None yet
Development

Successfully merging a pull request may close this issue.