Products can't be added to Outgoing O/C (Aus Customer)

[emilyjeanrogers]

Description

Products can't be added to Order Cycle. When customer clicks on expand arrow to view Products in Outgoing Products tab of Order Cycle, this message appears:

Loading..

Expanded product list never loads. Products cannot be added to Order Cycle.

Expected Behavior

List of Products available to add to Outgoing should appear.

Actual Behaviour

Customer sees message:

Loading..

When logged in as Superadmin and viewing this Order Cycle, this error appears:

[missing %{num_of_variants_loaded} value] of 428 Variants Loaded

Steps to Reproduce

1. Go to any Order Cycle for Baw Baw Food Hub (current order cycle closes 19 July 2020)
2. Go to Outgoing Tab
3. Click on Expand arrow in Products
4. Error (when logged in as Superadmin)
5. Loading... (when logged in as Manager of Enterprise)

Animated Gif/Screenshot

Workaround

No workaround. Can't add products to Order Cycle (Order Cycle is currently open, but new products need to be added)

Severity

Your Environment

Possible Fix

[luisramos0]

Maybe time to activate bugsnag JS on the backoffice...
If we had that, we would see the JS error on the user browser.

@emilyjeanrogers if you are doing user support and can replicate errors, it's useful if you can provide the data available in the browser dev tools. I managed to reproduce in this case and I can see this:

It's usually on the console tab or the network tab (like in this case) and then on the network tab, on the line with a non-green color.

Anyway, now we need to find out why this syntax error is poping up for this hub.

[luisramos0]

I can confirm this is a v3regression.

Something changed about the SQL that is generated here:

openfoodnetwork/app/services/exchange_products_renderer.rb

Lines 48 to 52 in 4e3502c

	def products_for_outgoing_exchange
	supplied_products(enterprises_for_outgoing_exchange.select(:id)).
	includes(:variants).
	where("spree_variants.id": incoming_exchanges_variants)
	end

The problem only occurs if filter_visible is used in the supplied_products method.

I tried changing the OC settings to not filter on "coordinator only" and found that it's not working in v3 🙈

This would have been the quick workaround for this issue because this bug only happens if the "coordinator inventory only" filter is selected. So, this is issue only happens if the option on the left is selected.

This bug in the form (cant change the OC config) is very easy to fix but maybe even before a PR is created, as a quick workaround, we can change the value directly in the database so that the Hub can operate immediately?

[luisramos0]

This is also fairly easy to replicate with sample data. Just activate the OC setting "coordinator inventory only" and go to outgoing exchanges, it breaks for me with sample data (added Fred's Garlic to Fredo's Inventory and tried to sell it in an OC with the filter on).

[RachL]

@luisramos0 do we have automated tests for this? Or can they be added as part of the fix? I must admit that on my side I never test this option during release testing :(

[luisramos0]

Yeah, I have the code fix done in #5775 I need to write some tests now.

[luisramos0]

The PR is ready for review now.
@RachL we now have 2 simple auto tests that make sure:

1. no products are shown if this option is active and the coordinator's inventory is empty
   2 that only a specific variant added to the coordinator's inventory will show in the exchanges if the option is active