Fix calendar picker day selection

[Gr33nR10t]

What? Why?
In the Italian instance when a user open a cycle order the calendar picker doesn't show the correct date on the text box.
After choosing the day there are AA and GG instead 2020 and 12.

What should we test?
Log in as enterprise user or super admin
Change your language to other than english
Go to the order cycles menu
Create a new order cycle or edit a current one
See the calendar dropdown
This dropdown also appears in the "reports" menu

[luisramos0]

this must be caused by this PR #5995

[andresgutgon]

I can't reproduce in my local Docker dev env

Must be something related with the italian instance but not sure how to reproduce :/

[andresgutgon]

Ok, for some reason I see all site in italian but not javascript translations.

What I see the error (Is my theory) comes from Ruby / SpreeI18n gem misconfiguration:

[andresgutgon]

We're overriting italian locale 😅

[luisramos0]

As per discussion in the PR #6218 this problem is caused by translators that change the date format to something not valid, in this case aa-mm-gg where it should always be something with yy/mm/dd

This is happening in quite a few languages in transifex. The fix to this is to update the translation in transifex to use valid formats with yy mm dd. Same applies to the format key where entries like %Y and %m should always be used.

I think we should keep this issue open because we should eliminate the root cause: the root cause is the fact that we are mixing configurations with translations. These entries should not be translations but more configurations. I'd make this issue a request to move these entries from en.yml to some config file.

[andresgutgon]

To keep everything working the same way, with Rails locales system I would just move these copies to another .yml file:

locales/
  en.yml
  skip_translators/
    en.yml

And exclude skip_translators folder from Transifex process

[luisramos0]

nice Andres, thanks a lot for that suggestion 👌
We have a few more candidate translation keys for that already...

[lin-d-hop]

💥