Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rspec-rails to 4.1 #7050

Closed
andrewpbrett opened this issue Mar 9, 2021 · 1 comment · Fixed by #7067
Closed

Upgrade rspec-rails to 4.1 #7050

andrewpbrett opened this issue Mar 9, 2021 · 1 comment · Fixed by #7067
Labels
tech debt

Comments

@andrewpbrett
Copy link
Contributor

andrewpbrett commented Mar 9, 2021 •
edited by sigmundpetersen

What we should change and why (this is tech debt)

Broken build from dependabot when trying to upgrade.

Context

#7038
#7061

Impact and timeline
@andrewpbrett andrewpbrett mentioned this issue Mar 9, 2021
Closed
@sigmundpetersen sigmundpetersen mentioned this issue Mar 10, 2021
Closed
@sigmundpetersen
Copy link
Contributor

The build for 4.1.2 looks much healthier #7067
They also released a 5.0.0 which is dropping support for Rails <5.2, so I'm guessing that broke the build and they reverted those changes into that 4.1.2

We can update the title of this issue to upgrade to 5.0 or just close it and let dependabot try the update after we get to 5.2

@andrewpbrett andrewpbrett mentioned this issue Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rspec-rails from 4.0.2 to 4.1.2 openfoodfoundation/openfoodnetwork
2 participants
@andrewpbrett @sigmundpetersen