Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bulk Order Management] Incorrect sorting by date: months sorted alphabetically instead of chronologically #9661

Closed
drummer83 opened this issue Sep 12, 2022 · 12 comments · Fixed by #10451
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons

Comments

@drummer83
Copy link
Contributor

Description

When sorting the orders on bulk order management page by 'completed at' date, the months are sorted alphabetically and not chronologically as you would expect.

Expected Behavior

Sorting ascending by date you would expect: July --> August --> September

Actual Behaviour

It is sorted alphabetically: August --> July --> September

Steps to Reproduce

  1. Go to /admin/orders/bulk_management
  2. Select date range covering three or more months
  3. Sort by date (click on 'completed at' in the table header)
  4. Observe the sorting

Animated Gif/Screenshot

image

Workaround

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used: staged 5a4b38e (master)
  • Browser name and version: Firefox 104.0 (64-bit)
  • Operating System and version (desktop or mobile): Ubuntu 20.04 LTS

Possible Fix

@drummer83 drummer83 added good first issue bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. labels Sep 12, 2022
@adam-rankn
Copy link

looks like a good first issue for me to tackle, will look into it

@drummer83
Copy link
Contributor Author

Welcome @AdamPRankin! Great to have you here!

Let us know if you get stuck!

Looking forward to your contributions! 😊

@sigmundpetersen sigmundpetersen added the hackathon Issues for upcoming hackathons label Sep 13, 2022
@RachL
Copy link
Contributor

RachL commented Sep 30, 2022

Hello @AdamPRankin ! I hope this message fins you well. Just checking in: are you still working on this issue?

@toshitapandey
Copy link

@RachL - If no one is working on this, can I pick this up?

@RachL
Copy link
Contributor

RachL commented Oct 14, 2022

@toshitapandey apologies for the late answer. If you are still interested yes go ahead, I've assigned it to you!

@cyrillefr
Copy link
Contributor

Hello @RachL , @drummer83 .
Since no one is assigned, may I work on that issue ?

@RachL
Copy link
Contributor

RachL commented Dec 8, 2022

hi @cyrillefr there are some changes going on in BOM atm so perhaps best to wait for these changes to be merge before we fix this. I will indicate the dependency issue 👍

@RachL RachL added the blocked label Dec 8, 2022
@cyrillefr
Copy link
Contributor

No problemo @RachL , I have the fix on my local machine. I will save it for later.

@RachL RachL added this to To triage (By the maintainers) in Welcome New Developers! Jan 13, 2023
@drummer83
Copy link
Contributor Author

Is this one still blocked? #10123 has been merged.

@RachL RachL removed the blocked label Feb 13, 2023
@RachL
Copy link
Contributor

RachL commented Feb 13, 2023

No we are good to go 👍

@cyrillefr
Copy link
Contributor

Hello @RachL & @drummer83,

May I work on this issue ? I made a patch 3 months ago, I hope it is still valid.
I am working on #9499 by now, but I can definitely check if my solution is ok within 2 days.

@RachL
Copy link
Contributor

RachL commented Feb 15, 2023

Hi @cyrillefr yes go ahead 💪 thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons
Projects
Welcome New Developers!
To triage (By the maintainers)
6 participants