Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Producer by First Nations led #18

Closed
kirstenalarsen opened this issue Mar 7, 2024 · 7 comments
Closed

Filter Producer by First Nations led #18

kirstenalarsen opened this issue Mar 7, 2024 · 7 comments
Assignees

Comments

@kirstenalarsen
Copy link

kirstenalarsen commented Mar 7, 2024

First Nations led filter is currently not working correctly

Image

Part of the problem might be data @mkllnk @mariocarabotta - can we confirm that the API is bringing the correct data? The results displayed on the page are showing some Producers as FNL that shouldn't be i.e. Pukawidgee, Bundarra and Murrnong (despite them all being named with Aboriginal words!!) I'm not sure the correct spot to look in the airtable, but when I'm looking I don't see them as having FNL set, so not sure why that flag is appearing on the profiles

Image

@mkllnk
Copy link
Member

mkllnk commented Mar 7, 2024

@JbPasquier acknowledged already that it's a framework issue on SiB side. The current version is feeding from the wrong field in the absence of being able to deal with the right field. Oh wait, just saw that one comment was edited:

I still have a framework issue with the first nation led filter on products list. A fix will come as soon as possible. - Edit: Fixed.

@JbPasquier, maybe you missed an earlier comment on Slack:

One thing we noticed is that the First Nations Led filter isn't right. There was no test data but we added that flag to an enterprise now: https://api.regenerative.org.au/webhook/regen/producer?id=recSrhBnWnzkFRS3y
There you can see the ofn:First_Nations_led field which is only present when set and then it's simply true (boolean).

I think that you are looking at ofn:First_Nations_country but you need to look at ofn:First_Nations_led.

@JbPasquier
Copy link

Oooh right, I was using the wrong field so. Fixed.

image

Can you add a produce to this producer to ensure that the filter on Products List works properly too?

@mkllnk
Copy link
Member

mkllnk commented Mar 7, 2024

@kirstenalarsen We can't add products to that enterprise but could we add that flag to another with products?

@JbPasquier
Copy link

JbPasquier commented Mar 7, 2024

Should I keep the First Nation Country when First Nations Led is false?

Like there for Pukawidgee for instance:

image

@mkllnk
Copy link
Member

mkllnk commented Mar 7, 2024

Should I keep the First Nation Country when First Nation Led is false?

Yes! In Australia, we all live on First Nation's Country but only very few organisations are led by Indigenous people. We want to acknowledge the traditional owners regardless of being indigenous to this land or not.

@kirstenalarsen
Copy link
Author

kirstenalarsen commented Mar 7, 2024 via email

@mariocarabotta
Copy link

working as expected, product filter as well (see The Regenerative Farm DR Example).

Moving to done, good job!

@mkllnk mkllnk closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants