Change Spree::Payment processing methods to use strict creation #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In a few cases during testing the processing methods were silently returning objects that were not valid, causing strange behaviour in places further removed from pricessing. This change makes it so that if there are issues with the object creation they are immediately obvious. This seemed like a safe change because I believe under normal circumstances these methods should never fail.
|
mmm could it be that the |
luisramos0
suggested changes
Jun 19, 2020
There was a problem hiding this comment.
I dont think we should do this. We are on for ofn openfoodfoundation/openfoodnetwork#4826. No more spree changes imo.
We should bring the full processing file to ofn and make the change and refactoring we want.
|
Great! that was the other option but this felt quicker 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes openfoodfoundation/openfoodnetwork#5449
A failure in creating the refund payment should fail loudly so we see it in Bugsnag. Check out the original commit message for more details.