Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Fee display in shopfront: displaying fee name instead of the type #8899

Closed
RachL opened this issue Sep 6, 2021 · 8 comments · Fixed by #9325
Closed

Admin Fee display in shopfront: displaying fee name instead of the type #8899

RachL opened this issue Sep 6, 2021 · 8 comments · Fixed by #9325
Assignees
Labels
papercut Labels papercuts after they've moved from the "Papercuts prioritized" column

Comments

@RachL
Copy link
Contributor

RachL commented Sep 6, 2021

Description

- As a: (enterprise user, super admin, user...) Shopper
- On page: (provide url of the page you want to modify. If not provide where will be created the new url and the name we want to give it) Shopfront
- I want to be able to: (specify the desired behavior) ee the name of enterprise fees specified by enterpise

Enterprise fees have 'types' associated with them: - admin, sales, transport, packing, fundraising
This is a Spree legacy and doesn't have a reflection on taxes or functionality. It simply creates a point of confusion for users.

This issue is part of a 3part epic to remove these fee types.

Part 1. Removing them from the shopfront.
Currently the fee type is displayed in the shopfront within the 'pie chart' feature
Screenshot from 2022-02-16 14-10-16

Instead of the fee types these should have the fee names that have been entered here:
Screenshot from 2022-02-16 14-15-49

So from the image above the Pie Chart should now say '100% special' instead of 'Fundraising Fee' as it would say now.

Acceptance Criteria & Tests

  1. All types of fees should now display in the pie chart with the Fee Name instead.
  2. Front end developer should take into consideration how the Fee Name length will render on different devices. If the name is too long it should be truncated with a ... to ensure it renders well. Any max should be noted in the issue fro additional testing.
@jaycmb
Copy link
Collaborator

jaycmb commented Sep 9, 2021

Updated description to make it a bit clearer what the task is.

So this papercut would only address changes to shopfront display then? Do we need another issue for invoices?

@RachL
Copy link
Contributor Author

RachL commented Sep 9, 2021

I thought it didn't fit to papercut to do both at the same time, but maybe I missunderstood?

@jaycmb
Copy link
Collaborator

jaycmb commented Sep 9, 2021

Yep, I believe that´s what we said :)

I m just doublechecking since in the original issue we also discussed invoices it should be consistant what the user sees as fees in the shopfront and in the end on their invoice?
I just imagine it could be confusing if we have different terms along the user journey (and counterproductive to the price transparency claim)

@RachL
Copy link
Contributor Author

RachL commented Sep 9, 2021

Yes a second issue is needed in that case, I was just checking if the two couldn't be done at the same time.

@lin-d-hop lin-d-hop transferred this issue from openfoodfoundation/wishlist Feb 16, 2022
@lin-d-hop lin-d-hop changed the title Shopfront: displaying the name of the fee instead of the type Admin Fee display in shopfront: displaying fee name instead of the type Feb 16, 2022
@lin-d-hop lin-d-hop added papercut Labels papercuts after they've moved from the "Papercuts prioritized" column and removed Confirmed Papercut labels Feb 16, 2022
@RachL RachL added this to To triage (By the maintainers) in Welcome New Developers! Feb 16, 2022
@SarvarKh
Copy link
Contributor

Pie chart reflects price break_down with fee_types instead of fee_names through price_breakdown.html.haml.

So far, I couldn't find where variant variable in the above file is defined.
It must be quite simple, but I am new to Angular - I used React & Redux for the front-end.
FYI: I just bought a course to familiarize myself with Angular.js

Would appreciate your help🙏

@SarvarKh
Copy link
Contributor

Ok, variant variable doesn't comprise fee names.
So, need to define and then display them.

Screen Shot 2022-02-23 at 09 21 29

@tschumilas tschumilas added the CA Selected to be done by the Canadian active instance label Feb 23, 2022
@RachL RachL removed the CA Selected to be done by the Canadian active instance label Feb 24, 2022
@RachL RachL moved this from To triage (By the maintainers) to In progress in Welcome New Developers! Feb 24, 2022
@apricot12 apricot12 self-assigned this Apr 26, 2022
@RachL
Copy link
Contributor Author

RachL commented Jun 8, 2022

hello @apricot12 are you still working on this one?

@apricot12
Copy link
Contributor

hello @apricot12 are you still working on this one?

Yes I start on this one today 🙂. Sorry I take a long time to get to the things I assigned.

@tschumilas tschumilas added the CA Selected to be done by the Canadian active instance label Jun 23, 2022
Welcome New Developers! automation moved this from In progress to Done Jun 24, 2022
@RachL RachL removed the CA Selected to be done by the Canadian active instance label Jun 25, 2022
@jibees jibees self-assigned this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercut Labels papercuts after they've moved from the "Papercuts prioritized" column
Projects
7 participants