Add missing matches #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 16, 2016 17:32
…day 25, Premier League, 13/14. See hhttp://www.kicker.de/news/fussball/intligen/england/barclays-premier-league/2013-14/25/0/spieltag.html
markusz
pushed a commit
to markusz/es-espana
that referenced
this pull request
Jan 17, 2016
After closer investigation, openfootball/football.json#3 seems to be caused by typos in the source data
markusz
pushed a commit
to markusz/de-deutschland
that referenced
this pull request
Jan 17, 2016
After closer investigation, openfootball/football.json#3 seems to be caused by typos in the source data
markusz
pushed a commit
to markusz/eng-england
that referenced
this pull request
Jan 17, 2016
After closer investigation, openfootball/football.json#3 seems to be caused by typos in the source data
markusz
pushed a commit
to markusz/it-italy
that referenced
this pull request
Jan 17, 2016
After closer investigation, openfootball/football.json#3 seems to be caused by typos in the source data
|
After closer investigation, this seems to be caused by typos in the source data after all. I suppose this pull request will be redundant once the others to the source data are merged and files are regenerated |
|
Thanks for your efforts and the fix in the source. Great help. Note: Changes here get overwritten with the next build (but thanks to your fixes the missing matches should be now included). Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some matches are missing in the generated JSON file, although being in the source files (see individual commits).
This pull request adds the missing matches directly to the JSONized project, since the source data is correct and the error must have happened during processing and
Note: [..] please do NOT edit the JSON files but the source files in the country repos e.g.:is not a feasible solution hereI added kicker.de links to verify the correctness of my changes