Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refinement of API docs #177

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Review and refinement of API docs #177

merged 6 commits into from
Sep 8, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Sep 2, 2023

Working on making the API docs more polished.
Closes #32.

@dotsdl
Copy link
Member Author

dotsdl commented Sep 2, 2023

I think I've gone about as far as I'd like to go on this. There are surely objects and methods that could use better documentation, but this is better done gradually as we notice gaps than trying to do it in one PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (b7c90ee) 81.98% compared to head (50a63a8) 82.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   81.98%   82.01%   +0.03%     
==========================================
  Files          21       21              
  Lines        2681     2680       -1     
==========================================
  Hits         2198     2198              
+ Misses        483      482       -1     
Files Changed Coverage Δ
alchemiscale/base/api.py 86.48% <ø> (ø)
alchemiscale/base/client.py 78.08% <ø> (ø)
alchemiscale/cli.py 78.08% <ø> (ø)
alchemiscale/compute/api.py 63.91% <ø> (ø)
alchemiscale/compute/client.py 100.00% <ø> (ø)
alchemiscale/compute/service.py 81.28% <ø> (ø)
alchemiscale/interface/api.py 41.36% <ø> (ø)
alchemiscale/interface/client.py 90.80% <ø> (ø)
alchemiscale/models.py 97.16% <ø> (ø)
alchemiscale/security/auth.py 89.18% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @dotsdl. One thing I might add is mentioning the permissive MIT licensing in developer docs, or even on home page of the docs (only if you like).

@dotsdl
Copy link
Member Author

dotsdl commented Sep 8, 2023

Thanks @hmacdope! Added this to the top-level index for the docs!

@dotsdl dotsdl merged commit a32a5f4 into main Sep 8, 2023
5 checks passed
@dotsdl dotsdl deleted the api-docs branch September 8, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs : API reference
3 participants