Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added n_retries usage for SynchronousComputeService #186

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Oct 6, 2023

Closes #185.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a20f20) 82.73% compared to head (12f2759) 82.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   82.73%   82.26%   -0.48%     
==========================================
  Files          21       21              
  Lines        2722     2723       +1     
==========================================
- Hits         2252     2240      -12     
- Misses        470      483      +13     
Files Coverage Δ
alchemiscale/compute/service.py 81.38% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl dotsdl merged commit b5a4e58 into main Oct 6, 2023
5 checks passed
@dotsdl dotsdl deleted the compute-n_retries branch October 6, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set n_retries to greater than 0 (3 - 5) for SynchronousComputeService; make configurable via settings
2 participants