Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum for openmmforcefields version in conda envs to 0.12.0 #193

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Oct 19, 2023

Even though 0.12.0 is currently the latest version of openmmforcefields, building the env without forcing it appears to get 0.11.2 at the moment.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (813cc5a) 82.85% compared to head (36efbda) 82.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   82.85%   82.26%   -0.59%     
==========================================
  Files          22       22              
  Lines        2735     2735              
==========================================
- Hits         2266     2250      -16     
- Misses        469      485      +16     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl
Copy link
Member Author

dotsdl commented Oct 19, 2023

Looks like ambertools is keeping us from using python 3.11? @mikemhenry any insights as to why this may suddenly be the case with openmmtools 0.12.0?

I'm fine with downgrading to Python 3.10 in this instance, but wanted to raise this as odd in case it's the first we've seen it.

@mikemhenry
Copy link
Collaborator

We don't have python 3.11 builds for older ambertools, and we can't use the newest openmmtools with the older ambertools.

Does that make sense? In a perfect world, I would do a amber22 build for python 3.11

@dotsdl
Copy link
Member Author

dotsdl commented Oct 19, 2023

@mikemhenry yes, that makes sense. As discussed today, can you take a stab at getting an ambertools 22 build for Python 3.11, since I think without that, practically the whole openforcefield stack and everything using it will be held back to Python 3.10. Not exactly urgent, but seems unlikely to resolve on its own?

For (my future) reference, here is the pin that holds us back from ambertools 23: https://github.com/conda-forge/openmmforcefields-feedstock/blob/543afe9bd8fc8e6dbc3084ba59d0bfeaa26a358b/recipe/meta.yaml#L25

@dotsdl
Copy link
Member Author

dotsdl commented Oct 19, 2023

For the moment then here, we will remove Python 3.11 as a tested version, and proceed with deploying on Python 3.10. The CI for that version will always fail at present given the problem above.

@dotsdl
Copy link
Member Author

dotsdl commented Oct 20, 2023

Decided to keep 3.11 CI test; we don't require it to pass before merge, so this keeps it around as a reminder that this needs fixing. May revisit this decision if it proves annoying having it around.

@dotsdl dotsdl merged commit b8a9182 into main Oct 20, 2023
4 of 5 checks passed
@dotsdl dotsdl deleted the conda-openmmforcefields-0.12.0 branch October 20, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants