Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the visualize kwarg to the create_network method #207

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

ianmkenney
Copy link
Collaborator

Fixes #156

Added the visualize kwarg to the create_network method.

Comment on lines +140 to +141
progress.start_task(task)
progress.update(task, total=1, completed=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the reason we do start_task after we actually perform the operation is that we really just care about showing how much time has elapsed to the user as part of our indication that the client is busy doing something. We then immediately set progress to complete (progress.update) after "starting" it (progress.start) as outlined here: https://rich.readthedocs.io/en/stable/progress.html#indeterminate-progress

Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ianmkenney! Only one suggestion; please merge after considering it.

alchemiscale/interface/client.py Outdated Show resolved Hide resolved
Co-authored-by: David L. Dotson <dotsdl@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d59001) 82.74% compared to head (06e7bfd) 82.25%.

Files Patch % Lines
alchemiscale/interface/client.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   82.74%   82.25%   -0.49%     
==========================================
  Files          22       22              
  Lines        2735     2739       +4     
==========================================
- Hits         2263     2253      -10     
- Misses        472      486      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmkenney ianmkenney merged commit 76c439c into main Dec 4, 2023
4 checks passed
@ianmkenney ianmkenney deleted the 156-visualize-create_network branch December 4, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visualize kwarg to AlchemiscaleClient.create_network
3 participants