-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the visualize
kwarg to the create_network
method
#207
Conversation
136ea4d
to
9f9de11
Compare
progress.start_task(task) | ||
progress.update(task, total=1, completed=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the reason we do start_task
after we actually perform the operation is that we really just care about showing how much time has elapsed to the user as part of our indication that the client is busy doing something. We then immediately set progress to complete (progress.update
) after "starting" it (progress.start
) as outlined here: https://rich.readthedocs.io/en/stable/progress.html#indeterminate-progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @ianmkenney! Only one suggestion; please merge after considering it.
Co-authored-by: David L. Dotson <dotsdl@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 82.74% 82.25% -0.49%
==========================================
Files 22 22
Lines 2735 2739 +4
==========================================
- Hits 2263 2253 -10
- Misses 472 486 +14 ☔ View full report in Codecov by Sentry. |
Fixes #156
Added the visualize kwarg to the
create_network
method.