Add get_network_actioned_tasks and get_task_actioned_networks to AlchemicaleClient
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented methods: get_taskhub_actioned_tasks and get_task_actioned_networks * Added tests: test_get_taskhub_actioned_tasks and test_get_task_actioned_networks
* Added get_network_actioned_tasks to client * Added get_network_actioned_tasks endpoint to API * Added tests for Alchemiscale.get_network_actioned_tasks
dotsdl
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Looking good so far @ianmkenney! Thanks for working on this!
alchemiscale/interface/client.py
Outdated
Comment on lines
649
to
651
| task | ||
| ScopedKey of a task which may or may | ||
|
|
There was a problem hiding this comment.
For symmetry with get_network_actioned_tasks, does it make sense to also add a task_weights kwarg?
ianmkenney
changed the title
get_network_actioned_tasks and get_task_actioned_networks to AlchemicaleClientget_network_actioned_tasks and get_task_actioned_networks to AlchemicaleClient
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 81.96% 81.69% -0.28%
==========================================
Files 22 22
Lines 2828 2873 +45
==========================================
+ Hits 2318 2347 +29
- Misses 510 526 +16 ☔ View full report in Codecov by Sentry. |
…ve weights This shortcuts a lot of unnecessary chatty communication between the API service and the database.
dotsdl
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Great work @ianmkenney! I made some major simplifications to the AlchemiscaleAPI methods by adding weights output to the Neo4jStore methods they call. Let me know if you are in favor of these changes; if so, we'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #173
This PR implements methods at the
statestore,interface/api, andinterface/clientlevels to give users access to Tasks andAlchemicalNetworksbased on their relationship with one another.