Attempting to fix seemingly random failures on CI

alchemiscale/interface/client.py

@@ -76,9 +76,9 @@ def get_scoped_key(self, obj: GufeTokenizable, scope: Scope) -> ScopedKey:
                 "Scope for a ScopedKey must be specific; it cannot contain wildcards."
             )
 
-    def check_exists(self, scoped_key: Scope) -> bool:
+    def check_exists(self, scoped_key: ScopedKey) -> bool:
         """Returns ``True`` if the given ScopedKey represents an object in the database."""
-        return self._get_resource("/exists/{scoped_key}")
+        return self._get_resource(f"/exists/{scoped_key}")
 
     def create_network(
         self,

alchemiscale/tests/integration/conftest.py

@@ -300,7 +300,7 @@ def protocoldagresults(tmpdir_factory, transformation):
     return pdrs
 
 
-@fixture(scope="module")
+@fixture
 def network_tyk2_failure(network_tyk2):
     transformation = list(network_tyk2.edges)[0]
 
@@ -316,12 +316,12 @@ def network_tyk2_failure(network_tyk2):
     )
 
 
-@fixture(scope="module")
+@fixture
 def transformation_failure(network_tyk2_failure):
     return [t for t in network_tyk2_failure.edges if t.name == "broken"][0]
 
 
-@fixture(scope="module")
+@fixture
 def protocoldagresults_failure(tmpdir_factory, transformation_failure):
     pdrs = []
     for i in range(3):

alchemiscale/tests/integration/interface/client/test_client.py

@@ -1211,13 +1211,30 @@ def test_get_transformation_and_network_failures(
 
         # select the transformation we want to compute
         an = network_tyk2_failure
-        user_client.create_network(an, scope_test)
-        transformation = [
-            t for t in list(an.edges) if isinstance(t.protocol, BrokenProtocol)
-        ][0]
+        network_sk = user_client.create_network(an, scope_test)
 
-        network_sk = user_client.get_scoped_key(an, scope_test)
-        transformation_sk = user_client.get_scoped_key(transformation, scope_test)
+        # seeing what appears to be random race condition in CI; adding this
+        # ensures full AlchemicalNetwork present before we proceed
+        while True:
+            try:
+                an_ = user_client.get_network(network_sk)
+
+                if an_ != an:
+                    raise Exception("Network out doesn't exactly match network in yet")
+                else:
+                    break
+            except:
+                sleep(0.1)
+
+        tf_sks = user_client.get_network_transformations(network_sk)
+
+        # select the transformation we want to compute
+        for tf_sk in tf_sks:
+            tf = user_client.get_transformation(tf_sk)
+            if tf.name == "broken":
+                transformation_sk = tf_sk
+                transformation = tf
+                break
 
         # user client : create tasks for the transformation
         tasks = user_client.create_tasks(transformation_sk, count=2)
@@ -1333,21 +1350,31 @@ def test_get_task_failures(
 
         # select the transformation we want to compute
         an = network_tyk2_failure
-        an_sk = user_client.create_network(an, scope_test)
-        transformation = [
-            t for t in list(an.edges) if isinstance(t.protocol, BrokenProtocol)
-        ][0]
+        network_sk = user_client.create_network(an, scope_test)
 
-        tf_sks = user_client.get_network_transformations(an_sk)
+        # seeing what appears to be random race condition in CI; adding this
+        # ensures full AlchemicalNetwork present before we proceed
+        while True:
+            try:
+                an_ = user_client.get_network(network_sk)
 
+                if an_ != an:
+                    raise Exception("Network out doesn't exactly match network in yet")
+                else:
+                    break
+            except:
+                sleep(0.1)
+
+        tf_sks = user_client.get_network_transformations(network_sk)
+
+        # select the transformation we want to compute
         for tf_sk in tf_sks:
             tf = user_client.get_transformation(tf_sk)
             if tf.name == "broken":
                 transformation_sk = tf_sk
+                transformation = tf
                 break
 
-        network_sk = an_sk
-
         # user client : create tasks for the transformation
         tasks = user_client.create_tasks(transformation_sk, count=2)