-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version menu #231
Fix version menu #231
Conversation
I've seen this problem in a few different repos, lets see if I can get lucky an unpining sphinx works
This didn't fix things but the openff docs are working, so I just need to check what they are doing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 82.21% 81.78% -0.44%
==========================================
Files 24 24
Lines 2964 2964
==========================================
- Hits 2437 2424 -13
- Misses 527 540 +13 ☔ View full report in Codecov by Sentry. |
This PR resolves #230 see: |
@dotsdl ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikemhenry! It's a shame things keep breaking with later and later sphinx versions, but I'm happy to take anything that works on this front! Really appreciate you diving into this one!
@mikemhenry it looks like our doc builds may now be failing following this merge: https://readthedocs.org/projects/alchemiscale/builds/23305648/ However, from the log output for the |
Not sure what caused the change, but the problem is these warnings: I can take a look |
@mikemhenry that appears to be a warning, and @ianmkenney reports that he can't reproduce the failure locally. Any other insights as to why readthedocs may be issuing a failure here? Otherwise, I may just revert this change to get docs building again, even if we don't have the version menu working. |
I've seen this problem in a few different repos, lets see if I can get lucky an unpining sphinx works