Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version menu #231

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix version menu #231

merged 2 commits into from
Feb 1, 2024

Conversation

mikemhenry
Copy link
Collaborator

I've seen this problem in a few different repos, lets see if I can get lucky an unpining sphinx works

I've seen this problem in a few different repos, lets see if I can get lucky an unpining sphinx works
@mikemhenry
Copy link
Collaborator Author

This didn't fix things but the openff docs are working, so I just need to check what they are doing

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6393f5) 82.21% compared to head (05e5787) 81.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   82.21%   81.78%   -0.44%     
==========================================
  Files          24       24              
  Lines        2964     2964              
==========================================
- Hits         2437     2424      -13     
- Misses        527      540      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Collaborator Author

mikemhenry commented Jan 24, 2024

@mikemhenry
Copy link
Collaborator Author

@dotsdl ready for review!

Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikemhenry! It's a shame things keep breaking with later and later sphinx versions, but I'm happy to take anything that works on this front! Really appreciate you diving into this one!

@dotsdl dotsdl merged commit 35aa569 into main Feb 1, 2024
4 checks passed
@dotsdl dotsdl deleted the unpin-sphinx branch February 1, 2024 05:26
@dotsdl
Copy link
Member

dotsdl commented Feb 2, 2024

@mikemhenry it looks like our doc builds may now be failing following this merge: https://readthedocs.org/projects/alchemiscale/builds/23305648/

However, from the log output for the sphinx build, it isn't clear to me at all what the failure is. Do you see anything that stands out to you?

@mikemhenry
Copy link
Collaborator Author

Not sure what caused the change, but the problem is these warnings:
/home/docs/checkouts/readthedocs.org/user_builds/alchemiscale/checkouts/latest/docs/user_guide.rst:487: WARNING: external py:class reference target not found: gufe.protocols.Protocol

I can take a look

@dotsdl
Copy link
Member

dotsdl commented Feb 14, 2024

@mikemhenry that appears to be a warning, and @ianmkenney reports that he can't reproduce the failure locally. Any other insights as to why readthedocs may be issuing a failure here?

Otherwise, I may just revert this change to get docs building again, even if we don't have the version menu working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants