Support Neo4j 5.x #242
Merged
Support Neo4j 5.x #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage a full replacement of the subgraph class makes things too complicated. Instead, we'll make new functions take in subgraphs as arguments and operate on those at a lower level.
More spot fixes
|
To get this working, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 81.69% 81.77% +0.07%
==========================================
Files 25 25
Lines 3049 3040 -9
==========================================
- Hits 2491 2486 -5
+ Misses 558 554 -4 ☔ View full report in Codecov by Sentry. |
|
This is ready for review after #235 is merged and we rebase this branch against |
|
@ianmkenney reviewing now! |
dotsdl
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Just one edit needed given changes in #235. Otherwise looks great @ianmkenney!
Co-authored-by: David L. Dotson <dotsdl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use of Neo4j 5.x with
alchemiscale.