Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Component : Identifier assignment #8

Closed
dotsdl opened this issue Nov 10, 2020 · 1 comment · Fixed by #16
Closed

Workflow Component : Identifier assignment #8

dotsdl opened this issue Nov 10, 2020 · 1 comment · Fixed by #16

Comments

@dotsdl
Copy link
Member

dotsdl commented Nov 10, 2020

Implemented in openff.benchmark.utils. Can be as simple as a function that takes as input group/company code (3-letter), all molecules (with predefined conformers, if present). Will then produce a mapping of identifiers to molecule objects as: COM-XXXXX-YY

  • three-letter company code (COM)
  • molecule-index (XXXXX)
  • numerical conformer-index (YY); 01, 02, 03,…

Note that with this approach, each molecule submitted in the dataset will have exactly one conformer. We would not be stacking multiple conformers into each Molecule.

@j-wags
Copy link
Member

j-wags commented Nov 11, 2020

This step will:

  • strip out all non-essential information from inputs (SD tags and such).
  • provide a record/mapping of input files to assigned IDs so subsequent steps can read it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants