Skip failing notebooks #44

Yoshanuikabundi · 2024-03-22T06:33:16Z

This PR skips notebooks that fail to execute and continues to render other notebooks.

Todo:

Sequential implementation of failure detection
Parallelize
Include failed notebooks in workflow finished PR comments
Fail when not all notebooks succeed

github-actions · 2024-03-22T06:33:30Z

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

Yoshanuikabundi · 2024-03-22T06:33:37Z

/regenerate-cache

github-actions · 2024-03-22T06:33:58Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8386463291
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-03-22T07:12:45Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8386463291
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: success

If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-04-04T04:33:38Z

/regenerate-cache

github-actions · 2024-04-04T04:33:58Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8549327114
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-04-04T05:15:39Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8549327114
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: success
Failing notebooks:
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-04-04T06:08:43Z

/regenerate-cache

github-actions · 2024-04-04T06:09:08Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8550071272
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-04-04T06:50:09Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8550071272
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: success
Failing notebooks:
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-04-04T07:39:54Z

/regenerate-cache

github-actions · 2024-04-04T07:40:18Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8551011375
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-04-04T08:21:07Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8551011375
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: success
Failing notebooks:
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-04-04T09:17:56Z

/regenerate-cache

github-actions · 2024-04-04T09:18:18Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8552253587
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-04-04T10:00:00Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8552253587
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: failure
Failing notebooks:
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-04-04T10:13:01Z

/regenerate-cache

github-actions · 2024-04-04T10:13:26Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8552952646
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-04-04T10:54:53Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8552952646
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Status: success
Failing notebooks: openforcefield/openff-toolkit/toolkit_showcase/toolkit_showcase.ipynb, ,
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

github-actions · 2024-05-02T04:41:03Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8918512113
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: failure
Notebooks status: N/A

Changes will only be visible in the ReadTheDocs preview after it has been [rebuilt].

Yoshanuikabundi · 2024-05-02T11:11:13Z

/regenerate-cache

github-actions · 2024-05-02T11:11:32Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8922882997
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-02T11:34:28Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8922882997
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: failure
Notebooks status: N/A

Changes will only be visible in the ReadTheDocs preview after it has been [rebuilt].

Yoshanuikabundi · 2024-05-02T11:37:00Z

/regenerate-cache

github-actions · 2024-05-02T11:37:20Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8923182574
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-02T12:04:04Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8923182574
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: failure
Notebooks status: N/A

Changes will only be visible in the ReadTheDocs preview after it has been [rebuilt].

Yoshanuikabundi · 2024-05-02T13:22:29Z

/regenerate-cache

github-actions · 2024-05-02T13:22:54Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8924625262
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-02T13:48:01Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8924625262
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: success
Notebooks status: 28 / 28 notebooks successfully executed
Failing notebooks:

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-05-03T04:45:05Z

/regenerate-cache

github-actions · 2024-05-03T04:45:25Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8934219524
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-03T05:15:57Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8934219524
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: failure
Notebooks status: 28 / 29 notebooks successfully executed
Failing notebooks:
- openforcefield/openff-interchange/experimental/openmmforcefields/gaff.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-05-03T06:38:29Z

/regenerate-cache

github-actions · 2024-05-03T06:38:49Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8935123487
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-03T07:08:50Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8935123487
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: success
Notebooks status: 28 / 29 notebooks successfully executed
Failing notebooks:
- openforcefield/openff-interchange/experimental/openmmforcefields/gaff.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-05-03T08:18:54Z

/regenerate-cache

github-actions · 2024-05-03T08:19:13Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8936131696
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-03T08:44:15Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8936131696
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: success
Notebooks status: 28 / 29 notebooks successfully executed (1 failures ignored)
Failing notebooks:
- openforcefield/openff-interchange/experimental/openmmforcefields/gaff.ipynb
- [ignored] openforcefield/openff-interchange/experimental/openmmforcefields/gaff.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Yoshanuikabundi · 2024-05-03T09:57:17Z

/regenerate-cache

github-actions · 2024-05-03T09:57:38Z

A workflow has been dispatched to regenerate the cookbook cache for this PR.

Run ID: 8937270407
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44

github-actions · 2024-05-03T10:32:41Z

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

Run ID: 8937270407
Triggering actor: github-actions[bot]
Target branch: skip-failing-notebooks
Deployment branch: _cookbook_data_PR44
Job status: failure
Notebooks status: 27 / 29 notebooks successfully executed (1 failures ignored)
Failing notebooks:
- openforcefield/openff-toolkit/virtual_sites/vsite_showcase.ipynb
- [ignored] openforcefield/openff-interchange/experimental/openmmforcefields/gaff.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt.

Initial sequential implementation of notebook failure detection

e528e97

Yoshanuikabundi added 5 commits March 22, 2024 18:21

More verbose summary

1eecb6f

Merge branch 'main' into skip-failing-notebooks

0878ff7

Keep log of failed notebooks

4ae10b0

Make failure log configurable

adf7c50

Report failed notebooks in PR

a27987d

Improve formatting and fix log filename

7dc329f

Fixes

b55d75b

str -> path

3119734

Keep failing notebooks env on one line

bb7c666

Try reporting failing notebooks as JSON

4ce82d3

More info for debugging

46833e2

Write long even on success

e215404

Fix link in status report fallback

0e1fb8a

typo

e275219

Add OPTIONAL_NOTEBOOKS setting

5efbc7d

Logic error

2f469dc

Report ignored notebooks

43020bf

Logic error

d26515c

Skip failing notebooks #44

Are you sure you want to change the base?

Skip failing notebooks #44

Conversation

Yoshanuikabundi commented Mar 22, 2024 • edited

github-actions bot commented Mar 22, 2024

Yoshanuikabundi commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

Yoshanuikabundi commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Yoshanuikabundi commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Yoshanuikabundi commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Yoshanuikabundi commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Yoshanuikabundi commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented May 2, 2024

Yoshanuikabundi commented May 2, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 2, 2024

Yoshanuikabundi commented May 2, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 2, 2024

Yoshanuikabundi commented May 2, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 2, 2024

Failing notebooks:

Yoshanuikabundi commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

Yoshanuikabundi commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

Yoshanuikabundi commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

Yoshanuikabundi commented May 3, 2024

github-actions bot commented May 3, 2024

github-actions bot commented May 3, 2024

Yoshanuikabundi commented Mar 22, 2024 •

edited