Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #397

Merged
merged 13 commits into from
Feb 24, 2022
Merged

Fix CI #397

merged 13 commits into from
Feb 24, 2022

Conversation

mattwthompson
Copy link
Member

No description provided.

@mattwthompson
Copy link
Member Author

Nothing is failing locally and I've updated my environment to match the file test_env.yaml tracked here.

Exit code 134 coming from a SIGABRT implies too much memory is being used. I used a pytest-monitor to see how much is being used locally and it tops out around 250 MB. This is higher than I'd prefer but well under the 2 GB limit that I think we're provided with these runners.

@mattwthompson
Copy link
Member Author

Here's the diff between envs that are failing and passing; deps on > lines or some interaction with them are causing the segfault. Again, this is not happening locally so it's tedious to debug.

1c1
< name: openff-interchange-minimal-env
---
> name: openff-interchange-env
3a4,5
>   - bioconda
>   - openeye
14a17,21
>   # Optional features
>   - jax
>   - unyt
>   - mbuild
>   - foyer >=0.8.1
15a23,27
>   - mdtraj
>   - intermol
>   - openff-evaluator
>   - openff-recharge
>   - openeye-toolkits
16a29,30
>   - codecov
>   - pytest-cov
17a32,34
>   - pytest-randomly
>   - pytest-timeout
>   - nbval
18a36,49
>   - nglview
>   # Drivers
>   - gromacs >=2021
>   - lammps
>   - panedr
>   # Typing
>   - mypy
>   - typing-extensions
>   - types-setuptools
>   - types-pkg_resources
>   - pandas-stubs
>   - openff-evaluator
>   - openff-recharge
>   - openeye-toolkits
21d51
<   - mdtraj

@mattwthompson
Copy link
Member Author

The problem is likely conda-forge/jaxlib-feedstock#89; I don't have the bandwidth to fix it so I have to pin around it.

@mattwthompson
Copy link
Member Author

Still kinda broken; may have to pip install jax if the issue persists

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #397 (c9cb5ad) into main (c83815a) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@mattwthompson
Copy link
Member Author

Docs still broken but I've already spent too much time getting CI passing

@mattwthompson mattwthompson merged commit 8a18ee2 into main Feb 24, 2022
@mattwthompson mattwthompson deleted the fix-ci-1 branch February 24, 2022 19:01
@xhochy
Copy link

xhochy commented Mar 7, 2022

@mattwthompson We've fixed the jaxlib issue and you should be able to revert this PR.

@mattwthompson
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants