Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise errors when from_openmm inputs are incompatible or unsupported #923

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Raise errors when from_openmm inputs are incompatible or unsupported #923

merged 2 commits into from
Mar 7, 2024

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Mar 6, 2024 •
edited
Loading

Description

#921

Checklist

  • Add tests
  • Lint
  • Update docstrings

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Merging #923 (6befe12) into main (ee82b4e) will increase coverage by 0.00%.
The diff coverage is 94.73%.

❗ Current head 6befe12 differs from pull request most recent head f989475. Consider uploading reports for the commit f989475 to get more accurate results

Additional details and impacted files

@mattwthompson
Copy link
Member Author

@Yoshanuikabundi any other compatibility cases I should be on the lookout for?

Yoshanuikabundi
Yoshanuikabundi approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@Yoshanuikabundi Yoshanuikabundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just remove the zero mass check.

openff/interchange/interop/openmm/_import/compat.py Outdated Show resolved Hide resolved
@mattwthompson mattwthompson marked this pull request as ready for review March 7, 2024 14:17
@mattwthompson mattwthompson merged commit f70880f into main Mar 7, 2024
28 of 29 checks passed
@mattwthompson mattwthompson mentioned this pull request Mar 7, 2024
Closed
@mattwthompson mattwthompson deleted the mismatch-test branch April 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoshanuikabundi Yoshanuikabundi Yoshanuikabundi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattwthompson @Yoshanuikabundi