Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring type-checking back online #996

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Bring type-checking back online #996

wants to merge 5 commits into from

Conversation

mattwthompson
Copy link
Member

Description

Provide a brief description of the PR's purpose here.

Checklist

  • Add tests
  • Lint
  • Update docstrings

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 86.29032% with 17 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (6a1fb9e) to head (7c542fa).

Additional details and impacted files

@mattwthompson
Copy link
Member Author

Something is funky here and unfortunately hard to work through

$ mypy -p "openff.interchange" --exclude "openff/interchange/_tests/"  13:31:51  ☁  mypy-return ☂
Traceback (most recent call last):
  File "/Users/mattthompson/micromamba/envs/openff-interchange-dev/bin/mypy", line 11, in <module>
    sys.exit(console_entry())
             ^^^^^^^^^^^^^^^
  File "/Users/mattthompson/micromamba/envs/openff-interchange-dev/lib/python3.11/site-packages/mypy/__main__.py", line 15, in console_entry
    main()
  File "mypy/main.py", line 100, in main
  File "mypy/main.py", line 182, in run_build
  File "mypy/build.py", line 192, in build
  File "mypy/build.py", line 266, in _build
  File "mypy/build.py", line 2942, in dispatch
  File "mypy/build.py", line 3340, in process_graph
  File "mypy/build.py", line 3468, in process_stale_scc
  File "mypy/build.py", line 2503, in write_cache
  File "mypy/build.py", line 1564, in write_cache
  File "mypy/nodes.py", line 387, in serialize
  File "mypy/nodes.py", line 3936, in serialize
  File "mypy/nodes.py", line 3873, in serialize
  File "mypy/nodes.py", line 3607, in serialize
  File "mypy/types.py", line 3020, in serialize
  File "mypy/types.py", line 667, in serialize
  File "mypy/types.py", line 3067, in serialize
AssertionError: Internal error: unresolved placeholder type None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant