Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #117

Merged
merged 3 commits into from
May 31, 2024
Merged

Fix CI #117

merged 3 commits into from
May 31, 2024

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Apr 25, 2024

GitHub just upgraded our org to have access to mac M1 runners. This is the new macos-latest in CI, and it causes tests to fail for several reasons of varying complexity. In the meantime, we can specifically request the old macos-12 runners to keep running CI the way it was before.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.34%. Comparing base (10c2555) to head (e1a0129).

Additional details and impacted files

@mattwthompson mattwthompson changed the title Change all mac runners to macos-12 Fix CI May 31, 2024
@mattwthompson mattwthompson merged commit e0fc989 into main May 31, 2024
62 checks passed
- dgl >=1.0
- dgl =2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's lot of stuff going on with GraphBolt in recent releases and similar stuff showed up in test failures: https://github.com/dmlc/dgl/releases

I got scared and basically guessed which works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants