Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset visualization with RDKit backend #257

Merged
merged 5 commits into from Jan 31, 2024
Merged

Fix dataset visualization with RDKit backend #257

merged 5 commits into from Jan 31, 2024

Conversation

mattwthompson
Copy link
Member

Fixes #200; I verified the bug and fix locally

mattwthompson and others added 2 commits January 30, 2024 10:33
@mattwthompson
Add returnPNG=False in RDKit visualization
dc74149 
Co-authored-by: Pavan Kumar <pavan.kumar@openforcefield.org>
@mattwthompson
Re-run one notebook
1c2f836
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited

Codecov Report

Merging #257 (2fbd047) into main (21e5492) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

j-wags
j-wags approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson! Please update releasenotes before merging.

@mattwthompson mattwthompson merged commit 60f4210 into main Jan 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dataset.visualize might fail with rdkit backend
2 participants
@mattwthompson @j-wags