Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #1719

Merged
merged 4 commits into from Sep 8, 2023
Merged

Update examples #1719

merged 4 commits into from Sep 8, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Sep 8, 2023 •
edited by j-wags

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Merging #1719 (d92528d) into main (b9bb6b2) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d92528d differs from pull request most recent head 32bd075. Consider uploading reports for the commit 32bd075 to get more accurate results

Additional details and impacted files

j-wags
j-wags reviewed Sep 8, 2023
View reviewed changes
examples/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb
@@ -18,14 +18,7 @@
{
Copy link
Member

@j-wags j-wags Sep 8, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description was upgraded to 2.1.0 but the code still points to 2.0.0


Reply via ReviewNB

@j-wags j-wags mentioned this pull request Sep 8, 2023
Closed
@j-wags
Copy link
Member

j-wags commented Sep 8, 2023

Thanks for opening this. I'll finish this PR.

j-wags
j-wags approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mattwthompson!

@j-wags j-wags marked this pull request as ready for review September 8, 2023 19:57
@j-wags j-wags merged commit c5ad6e4 into main Sep 8, 2023
1 of 17 checks passed
@j-wags j-wags deleted the update-examples branch September 8, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolkit Showcase examples has NGL errors
2 participants
@mattwthompson @j-wags