Annotate most everything

[mattwthompson]

Happy holidays @Yoshanuikabundi - I think I'll break this up into a few smaller changes but this is the gist of what is encompassed

• Move annotations from docstrings to function signatures
• Use check_untyped_defs = True
• Tag issue being addressed Move type annotations from docstrings to signatures wherever possible #1791
• Add tests
• Update docstrings/documentation, if applicable
• Lint codebase
• Update changelog

[codecov]

Codecov Report

Merging #1798 (45c7876) into main (b739698) will decrease coverage by 0.02%.
The diff coverage is 95.92%.

Additional details and impacted files

[Yoshanuikabundi]

This is awesome Matt, great work. I think I only found 1 mistake where there was some vestigial type annotation in a docstring, and all my other comments are pretty much just ways to get rid of type: ignore comments that you can adopt if you like. Sorry this took so long to review and thanks so much for doing it!

[Yoshanuikabundi]

This argument isn't used in the function body, so I guess it's ignored and just here to avoid a breaking change? If so we should document that it doesn't do anything or remove it.

@j-wags Any idea what this parameter is supposed to do?

[mattwthompson]

#1843

[mattwthompson]

Thanks for the review @Yoshanuikabundi - there are three loose ends I'm leaving unresolved, but I think everything else here is working!