Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ForceField.parse_sources docstring consistent with implementation #1804

Merged
merged 2 commits into from Jan 4, 2024
Merged

Make ForceField.parse_sources docstring consistent with implementation #1804

merged 2 commits into from Jan 4, 2024

Conversation

ntBre
Copy link
Contributor

@ntBre ntBre commented Jan 4, 2024 •
edited by j-wags

Handles #1803

@ntBre
make parse_sources docstring consistent with implementation
02c619e 
Also link to parse_sources from ForceField.__init__ docs
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited

Codecov Report

Merging #1804 (153066b) into main (1c1146a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

j-wags
j-wags approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've updated the releasehistory and will merge once the first run of tests pass. Thanks @ntBre

@ntBre
Copy link
Contributor Author

ntBre commented Jan 4, 2024

Awesome, thanks!

@j-wags j-wags merged commit 1c9b8c1 into main Jan 4, 2024
18 checks passed
@j-wags j-wags deleted the fix-1803 branch January 4, 2024 19:34
@j-wags j-wags mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntBre @j-wags