Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve hierarchy data in _SimpleMolecule.from_molecule #1811

Merged
merged 8 commits into from Jan 24, 2024
Merged

Preserve hierarchy data in _SimpleMolecule.from_molecule #1811

merged 8 commits into from Jan 24, 2024

Conversation

mattwthompson
Copy link
Member

Resolves #1810

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited

Codecov Report

Merging #1811 (9df264f) into main (b479325) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review January 22, 2024 20:16
j-wags
j-wags approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwthompson mattwthompson merged commit f7e2149 into main Jan 24, 2024
18 checks passed
@mattwthompson mattwthompson deleted the mm-metadata branch January 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve hierarchy metadata in _SimpleMolecule
2 participants
@mattwthompson @j-wags