New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper function to signify optional dependencies, soften serialization deps #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and works well on a technical level. I think that mdtraj
and xmltodict
shouldn't be decorated using the new decorator, so if my proposed changes about undecorating those are good, this is ready for merge. Please add this as a "new feature" in the release history.
if package_name in ["openforcefields", "smirnoff99frosst"]: | ||
self.msg += " -c omnia" | ||
super().__init__(self.msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Co-authored-by: Jeff Wagner <jwagnerjpl@gmail.com>
This pull request introduces 1 alert when merging d0197fe into a148678 - view on LGTM.com new alerts:
|
Resolves #772 - but might be best to hold off merging until the
conda-forge
migration is complete and the dust has settled.smirnoff99frosst
mdtraj
nglview
toml
yaml
bson
xmltodict
msgpack
openmmtools
Heres's what it looks like at the moment (verbose but instructive; will wrap these into tests):