Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes vdW rmin_half / sigma conversion #808

Merged
merged 6 commits into from Jan 8, 2021
Merged

Fixes vdW rmin_half / sigma conversion #808

merged 6 commits into from Jan 8, 2021

Conversation

SimonBoothroyd
Copy link
Contributor

@SimonBoothroyd SimonBoothroyd commented Jan 8, 2021 •
edited

@codecov
Copy link

codecov bot commented Jan 8, 2021 •
edited

Codecov Report

Merging #808 (354838e) into master (a8c12ce) will not change coverage.
The diff coverage is 100.00%.

j-wags
j-wags approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks @SimonBoothroyd and @mattwthompson for the hasty work on this!

@j-wags j-wags merged commit d9d8e73 into master Jan 8, 2021
@j-wags j-wags deleted the fix-vdw-sigma branch January 8, 2021 22:17
@mattwthompson mattwthompson mentioned this pull request Aug 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

@mattwthompson mattwthompson Awaiting requested review from mattwthompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VdW Sigma Incorrectly Calculated
3 participants
@SimonBoothroyd @j-wags @mattwthompson