Merge pull request #5 from openforge/cta-fixes

fix: change stencil-router-links to a-hrefs for ctas Closes #3
openforge · Mar 30, 2018 · a5eafeb · a5eafeb
2 parents 9ca16ab + 0ade034
commit a5eafeb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/components/app-cta/app-cta.tsx b/src/components/app-cta/app-cta.tsx
@@ -17,11 +17,13 @@ export class AppCta {
             <slot name="header" />
           </h3>
 
-          <stencil-route-link url={this.linkUrl}>
-            <a class="btn btn-primary align-self-center">
-              <slot name="link" />
-            </a>
-          </stencil-route-link>
+          <a
+            href={this.linkUrl}
+            class="btn btn-primary align-self-center"
+            target="_blank"
+          >
+            <slot name="link" />
+          </a>
         </div>
       </aside>
     );

diff --git a/src/components/app-hero/app-hero.tsx b/src/components/app-hero/app-hero.tsx
@@ -29,11 +29,9 @@ export class AppHero {
                 <slot name="body" />
               </p>
 
-              <stencil-route-link url={this.linkUrl}>
-                <a class="btn btn-primary">
-                  <slot name="link" />
-                </a>
-              </stencil-route-link>
+              <a href={this.linkUrl} class="btn btn-primary" target="_blank">
+                <slot name="link" />
+              </a>
             </div>
           </div>
         </div>