Skip to content
This repository has been archived by the owner on Feb 5, 2022. It is now read-only.

feature(spa + seo): structured data #74

Closed
jedihacks opened this issue May 28, 2018 · 3 comments
Closed

feature(spa + seo): structured data #74

jedihacks opened this issue May 28, 2018 · 3 comments
Assignees
Labels
QA Ready Fix is staged and ready for QA

Comments

@jedihacks
Copy link
Member

Single Page Web apps (SPA's) have certain configurations that need to be performed in order to properly index data for Google's crawler.

One of those pieces is Structured Data, which is described here: https://developers.google.com/search/docs/guides/intro-structured-data?visit_id=1-636631240128162327-3698134189&hl=en&rd=1

I've created two property listings on Search Console, and added Billy, Geoff, Paulina, and Luis to the listing.

https://www.google.com/webmasters/tools/dashboard?siteUrl=http://www.openforge.io/

Whoever takes this task, please do the following:

  1. Research structured data and the links above
  2. Create proposed data structure for our pages. Feel free to bring someone in to pair program with you.
  3. Add me as a reviewer when it's ready for code review or when you need keywords.
@Fdom92 Fdom92 self-assigned this May 29, 2018
@Fdom92
Copy link
Contributor

Fdom92 commented May 29, 2018

I added the initial structured data in this PR #82 just let me know if i'm missing some information @jedihacks

@PaulPaulDevelops
Copy link
Member

The initial structured data is causing an issue on develop when running npm start. The error is copied down below -

[06:40.1] prerendering failed in 1.49 s
[06:40.1] inject manifest into service worker finished in 711 ms
[ ERROR ] Minify JS
Unexpected token: punc (:)
[06:40.1]
build failed in 12.01 s

@LizCottrell LizCottrell changed the title SPA & SEO Enhancements - Structured Data feature(spa + seo): structured data Jun 11, 2018
@LizCottrell LizCottrell added backlog Not approved for development and removed change order labels Jun 11, 2018
@Geoff-Openforge Geoff-Openforge added QA Ready Fix is staged and ready for QA and removed backlog Not approved for development labels Jun 12, 2018
@Wholloran
Copy link
Contributor

Closing the ticket, after next iteration of changes are made I will rerun lighthouse and open a new ticket if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Ready Fix is staged and ready for QA
Projects
None yet
Development

No branches or pull requests

6 participants