Skip to content
This repository has been archived by the owner on Feb 5, 2022. It is now read-only.

Feature/butter cms #346

Merged
merged 64 commits into from
Apr 15, 2019
Merged

Feature/butter cms #346

merged 64 commits into from
Apr 15, 2019

Conversation

mm716783
Copy link
Contributor

Blog implementation, styles, prerendering, and webhooks

Matt Moran and others added 30 commits February 25, 2019 12:29
added master detail routing for blog posts, added some basic styles
fixed issue with localStorage
added index to track links for pre-render
upgraded stencil and resolved dependency issues
implemented featured post and categories for blog, including separate state for search results and
results filtered by category
created components for blog-featured and blog-content and wired them up, and wired up section for
Read Next posts
added layout styling to blog pages. still need to add styling for fonts and fine-tune padding, etc.
disabled filters on search
attempting to prerender
changed prerender to use pre-build script to fetch data
add prerender-blog-data to gitignore
fix author slug
set up firebase function to handle blog webhook from butter and relay to travis for rebuild
@Geoff-Openforge
Copy link

Things that need some styling changes:

  1. Add spacing in between each post on the blog landing pages where the blogs are listed out and a horizontal line in between each blog as well. See:
  2. The blog featured images stretch & distort when changing the browser window size
  3. Can we make the blog featured images clickable to link to the blogs?
  4. On the main featured post at the top of the landing page, can we make the title and image both link the to that blog?
  5. Underline the page# that is active at the bottom of the blog landing page
  6. When there aren't enough blogs to make the landing pages paginated, the bottom blog is right against the footer of the site. Can we add a fair amount of padding here?

@luiskcs89
Copy link
Contributor

Fixed 1 and it should also fix 6 because it gives more padding.

@Wholloran
Copy link
Contributor

The following are items that came from the QA Pass:

  1. The Profile image for "Billy" is displaying as broken on blogs with the publisher set to "billy" (As well as for Jedi). Note(For Same, Matt, and the receipts account displays a placeholder image from butter CMS, this is fine for users who don't have a profile picture on the website)
    https://openforge.teamwork.com/#tasks/13789798

  2. For filters with no content, this is being displayed: "No posts found for filter development." Let's change it to be "We don't currently have any blogs for this category. Check back soon!" This can be applied for all empty filter types.
    https://openforge.teamwork.com/#tasks/13789811

  3. The Read Next Section at the bottom of the blogs is blank with only a spinner. I let this sit for about 5 minutes and nothing populated. I'm assuming this should show the next three blog posts
    https://openforge.teamwork.com/#tasks/13789821

  4. The share buttons on the Blog pages are displaying as broken images
    https://openforge.teamwork.com/#tasks/13789828

  5. About the author, isn't populating the bio description for Billy & Jedi.
    https://openforge.teamwork.com/#tasks/13789863

  6. /blog Margins: (Desktop) The blogs under the categories are not using the correct margins. It should be on the same margins as the featured blog post
    https://openforge.teamwork.com/#tasks/13789878

  7. /blog-post Margins (Desktop): The specific blog posts aren't using the correct margins, they should be aligned with the navbar margins
    https://openforge.teamwork.com/#tasks/13789885

  8. Mobile(): Button on the featured article says "READ MORE" But as per designs should say "See WHAT'S INSIDE"
    https://openforge.teamwork.com/#tasks/13789888

  9. Mobile /blog The user image should be smaller, it's causing the user's name to fall onto the second line even when they have shorter names
    https://openforge.teamwork.com/#tasks/13789892

  10. mobile: when the drop-down is set to for announcements the line on the side of is will become shorter, however, when you switch back to a smaller category name ("Design") the lines don't go back to the correct size. attempt to mimic the mobile designs and we make any adjustments after the restructure is pushed)
    https://openforge.teamwork.com/#tasks/13789920

  11. Tablet(): /blog
    So we didn't have designs for a tablet but I talked with Rachel and we are going to have tablet have the stacked look (Like we do with mobile) in order to cut down on the strech images
    https://openforge.teamwork.com/#tasks/13789929

  12. Tablet: bio-image on blog post page is being stretched
    https://openforge.teamwork.com/#tasks/13789939

Sam H and others added 2 commits March 28, 2019 10:00
…nto feature/butter-cms

# Conflicts:
#	src/pages/open-forge-app/open-forge-app.tsx
@PaulPaulDevelops
Copy link
Member

PaulPaulDevelops commented Apr 1, 2019

1, 4, and 5 are set within the ButterCMS portal. If you do not have social media, bio, or photo listed it will not display (as it is an empty source).

The others I will look into in the meantime. I wanted to make a note about those as there will not be fixes at the moment.

@Wholloran
Copy link
Contributor

#3 is still happening

#11 looks way better overall, just going to make some more small requests

  • While emulating on the iPad, the categories aren't following the correct Margin (they go out to the ends of the screen)

#12 is still occurring (Not it's occurring on the iPad not iPad pro)

@Wholloran Wholloran merged commit 07e968f into develop Apr 15, 2019
@PaulPaulDevelops PaulPaulDevelops deleted the feature/butter-cms branch May 28, 2019 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants