Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToC accordion never scrolls; items on the bottom are obscured #210

Closed
cykusgdiv opened this issue Jun 19, 2016 · 1 comment
Closed

ToC accordion never scrolls; items on the bottom are obscured #210

cykusgdiv opened this issue Jun 19, 2016 · 1 comment

Comments

@cykusgdiv
Copy link

The accordion on the left side of every page that serves as the table of contents is never scrolled. As a result, when the accordion is expanded at a deep level, or at a part with many chapters, the items on the bottom of the accordion are never visible.

image

This is when the reader is at Basics > Ooops! > Overview. Items below "Approaches" are all obscured. Although the reader can see other items by clicking on "Approaches" - thereby collapsing the long "Basics" and expanding the much-shorter "Approaches" - IMHO this is inconvenient to the reader.

A possible simple fix is making the expanded accordion item collapsible by clicking on it. This allows the reader to make the accordion fully visible when in need to do so. However, considering the potential development of this project which may make the table of contents longer, enabling scroll of the accordion is probably a better idea in the long run.

@mikewesthad
Copy link
Member

@GreekFellows good point. I just implemented the simple fix version (8170b3b) of making the currently selected item collapsible. I agree that as the sidebar continues to grow, we'll need a more robust solution. Making the sidebar scrollable, independent of the chapter text, sounds like a good direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants