Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina fix, extra setWindowShape is not required #4346

Open
speps opened this issue Sep 7, 2015 · 2 comments
Open

Retina fix, extra setWindowShape is not required #4346

speps opened this issue Sep 7, 2015 · 2 comments
Milestone

Comments

@speps
Copy link

speps commented Sep 7, 2015

In ofAppGLFWWindow.cpp line 243, setWindowShape is not required, the window already has the right size.

Removing the line fixed it for me.

Tested on master branch, OS X 10.10.5, MacBook Pro Retina mid 2014.

I use the old trick I found on the forums to get Retina to work though, which is adding this line in the setup :

ofSetWindowShape(ofGetWidth(), ofGetHeight());

That doesn't have any effect without Retina so it doesn't matter. In the end, I don't know why Retina wouldn't work properly without the line.

@bilderbuchi
Copy link
Member

ping @openframeworks/macos

@speps
Copy link
Author

speps commented Sep 8, 2015

Note that this is working (the trick in setup) in 0.8.4. However, when I decided to use master, I noticed it didn't work anymore because ofMatrixStack does a glfwGetWindowSize before the setup is done.

@arturoc arturoc added this to the 0.10.0 milestone Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants