Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename testApp to ofApp #744

Closed
kylemcdonald opened this issue Sep 14, 2011 · 10 comments
Closed

rename testApp to ofApp #744

kylemcdonald opened this issue Sep 14, 2011 · 10 comments

Comments

@kylemcdonald
Copy link
Contributor

i think it would be wonderful if every OF example was named ofApp instead of testApp. especially because:

class ofApp : public ofBaseApp {

is more natural than:

class testApp : public ofBaseApp {

given the rest of OF naming conventions. and it would increase consistency with things like:

ofGetAppPtr();
ofAppBaseWindow
ofAppGlutWindow

this is a massive refactor that shouldn't be difficult, but should be done at the same time as something like a code formatting cleanup.

@joaquimrocha
Copy link
Contributor

I also would like to see this change pushed.

It sounds really weird to see projects (even commercial ones) based on OF using testApp. It makes it look like a simple test application.

@ddnn55
Copy link
Contributor

ddnn55 commented Oct 9, 2011

Wouldn't it make more sense to name each testApp to polygonExampleApp.h, oscReceiveExampleApp.h, etc.?

As I've recently realized, an "oF tutorial" is sometimes really more of a C++ tutorial. No one will necessarily figure out that the app name can be whatever they want unless they see many arbitrary examples.

@ybakos
Copy link

ybakos commented Oct 25, 2011

I agree, the default name of "ofApp" would be better than "testApp."

@ddnn55
Copy link
Contributor

ddnn55 commented Oct 25, 2011

I insist that actual unique names would be, educationally, by far the best.

graphicsExampleApp : public ofBaseApp {
polygonExampleApp : public ofBaseApp {

etc!

@arturoc
Copy link
Member

arturoc commented Oct 25, 2011

i agree with gimlids and actually programming interactivity uses it like that if i remember well

@kylemcdonald
Copy link
Contributor Author

i understand where david/gimlids is coming from. if OF didn't have an active community, it would certainly be the most logical option.

but i still argue for ofApp because i know that no one takes the time to change it on a per project basis (this is certain). seeing graphicsExampleApp and polygonExampleApp spread throughout the forum would just make it more annoying to share code with each other.

@ddnn55
Copy link
Contributor

ddnn55 commented Oct 26, 2011

That's valid.

@elliotwoods
Copy link
Contributor

I like ofApp

Brings us onto the renaming project from emptyExample issue in xcode4. Will bring that up on the forum

@timscaffidi
Copy link
Contributor

Couldn't we modify createProjects.py to automatically set the class name to whatever the new project name is? Is there a similar script for windows/mac?

so...
scripts/linux/createProjects.py apps/myApps/myFancyNewApp

would just autogen a myFancyNewApp project directory and make testApp.h/cpp -> myFancyNewApp.h/cpp

I used to just copy whatever was the closest example and start from that, but I love the cleanliness of createProjects.py

@openframeworks
Copy link
Collaborator

+1 for ofApp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants