We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I had an issue with scripts/linux/ubuntu/install_dependencies.sh. The call to lsb_release in
scripts/linux/ubuntu/install_dependencies.sh
lsb_release
if [ "$ID" = "elementary" ]; then # Gets ubuntu base version RELEASE=$(lsb_release -r -u) elif [ "$ID" = "linuxmint" ]; then # Gets ubuntu base version RELEASE=$(cat /etc/upstream-release/lsb-release | grep DISTRIB_RELEASE | cut -d "=" -f2) else RELEASE=$(lsb_release -r) fi
returns error if it is not installed and RELEASE ends up being empty resulting in wrong code path later on.
RELEASE
It's not a big deal but I noticed it while trying to automate the build process inside a docker container.
I think it would be a nice idea to try to install the tool with apt-get update && apt-get install -y lsb-release before it is used. What do you think?
apt-get update && apt-get install -y lsb-release
Thanks
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I had an issue with
scripts/linux/ubuntu/install_dependencies.sh
.The call to
lsb_release
inreturns error if it is not installed and
RELEASE
ends up being empty resulting in wrong code path later on.It's not a big deal but I noticed it while trying to automate the build process inside a docker container.
I think it would be a nice idea to try to install the tool with
apt-get update && apt-get install -y lsb-release
before it is used.What do you think?
Thanks
The text was updated successfully, but these errors were encountered: