Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for local addons to be specified via absolute paths #57

Merged
merged 1 commit into from Oct 19, 2015

Conversation

ofZach
Copy link
Contributor

@ofZach ofZach commented Oct 17, 2015

this is a PR to work through getting local addons to work in the gui.

I am allowing them to be specified at the command line via absolute paths which get converted to relative paths to the project in the command line tool as the project is generated (ie, if you have a folder called localAddons in the root, and you pass in -a"/users/......./ofxTemp" it will be like adding ../../../localAddons/ofxTemp to your project) . On the gui side, it's much easier to take a relative path to OF for the local addon (or absoute path) and store it internally as an absolute path....

I've added support in settings.json and in the gui now, just working on storing and passing through the right things, and on dealing with parsing addons.make on import.

as I get stuff to work, I'll check it in...

@arturoc
Copy link
Member

arturoc commented Oct 17, 2015

that makes a lot of sense, specifying paths from the command line as relative to the project was kind of strange. only thing, be careful that specifying things through addons.make still works as relative from the project

@ofZach
Copy link
Contributor Author

ofZach commented Oct 19, 2015

going to merge this even if we not using these absolute paths via the gui.... I feel like it's generally a useful thing to have as an option.

ofZach added a commit that referenced this pull request Oct 19, 2015
allow for local addons to be specified via absolute paths
@ofZach ofZach merged commit de8a2ef into master Oct 19, 2015
@arturoc arturoc deleted the localAddonsWork branch December 22, 2015 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants