add metrics #12

upamune · 2017-03-28T07:22:27Z

No description provided.

stormcat24 · 2017-03-28T07:22:31Z

metrics/metrics.go

+
+import metrics "github.com/rcrowley/go-metrics"
+
+type Metrics struct {


[golint]

[golint] exported type Metrics should have comment or be unexported

stormcat24 · 2017-03-28T07:22:31Z

metrics/metrics.go

+	clientCounterName = "counter"
+)
+
+func New() (Metrics, error) {


[golint]

[golint] exported function New should have comment or be unexported

stormcat24 · 2017-03-28T07:22:31Z

metrics/metrics.go

+	return m, nil
+}
+
+func (m *Metrics) IncClientCount() {


[golint]

[golint] exported method Metrics.IncClientCount should have comment or be unexported

stormcat24 · 2017-03-28T07:22:31Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(clientCounterName, m.registry).Inc(int64(1))
+}
+
+func (m *Metrics) DecClientCount() {


[golint]

[golint] exported method Metrics.DecClientCount should have comment or be unexported

stormcat24 · 2017-03-28T08:10:05Z

metrics/metrics.go

+	metrics "github.com/rcrowley/go-metrics"
+)
+
+type Metrics struct {


[golint]

[golint] exported type Metrics should have comment or be unexported

stormcat24 · 2017-03-28T08:10:06Z

metrics/metrics.go

+	clientCounterName = "counter"
+)
+
+func New() (Metrics, error) {


[golint]

[golint] exported function New should have comment or be unexported

stormcat24 · 2017-03-28T08:10:06Z

metrics/metrics.go

+	return m, nil
+}
+
+func (m *Metrics) IncClientCount() {


[golint]

[golint] exported method Metrics.IncClientCount should have comment or be unexported

stormcat24 · 2017-03-28T08:10:06Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(clientCounterName, m.registry).Inc(int64(1))
+}
+
+func (m *Metrics) DecClientCount() {


[golint]

[golint] exported method Metrics.DecClientCount should have comment or be unexported

stormcat24 · 2017-03-28T08:10:07Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(clientCounterName, m.registry).Dec(int64(1))
+}
+
+func (m *Metrics) WriteJSON(w io.Writer) {


[golint]

[golint] exported method Metrics.WriteJSON should have comment or be unexported

stormcat24 · 2017-03-28T08:10:07Z

server/metrics.go

+	"github.com/openfresh/plasma/metrics"
+)
+
+func NewMetricsServer(config config.Config, metrics []metrics.Metrics) *http.Server {


[golint]

[golint] exported function NewMetricsServer should have comment or be unexported

stormcat24 · 2017-03-28T08:57:03Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(clientCounterName, m.registry).Dec(int64(1))
+}
+
+func (m *Metrics) GetClientCount() int64 {


[golint]

[golint] exported method Metrics.GetClientCount should have comment or be unexported

stormcat24 · 2017-03-28T08:57:04Z

metrics/metrics.go

+	return metrics.GetOrRegisterCounter(clientCounterName, m.registry).Count()
+}
+
+func (m *Metrics) WriteJSON(w io.Writer) {


[golint]

[golint] exported method Metrics.WriteJSON should have comment or be unexported

stormcat24 · 2017-03-28T08:57:04Z

server/metrics.go

+	"github.com/openfresh/plasma/metrics"
+)
+
+func NewMetricsServer(config config.Config, metrics []metrics.Metrics) *http.Server {


[golint]

[golint] exported function NewMetricsServer should have comment or be unexported

stormcat24 · 2017-03-28T10:37:35Z

metrics/metrics.go

+)
+
+const (
+	GRPC = "grpc"


[golint]

[golint] exported const GRPC should have comment (or a comment on this block) or be unexported

stormcat24 · 2017-03-28T10:37:35Z

metrics/metrics.go

+	SSE  = "sse"
+)
+
+type Metrics struct {


[golint]

[golint] exported type Metrics should have comment or be unexported

stormcat24 · 2017-03-28T10:37:35Z

metrics/metrics.go

+	registry = metrics.NewRegistry()
+}
+
+type Registry metrics.Registry


[golint]

[golint] exported type Registry should have comment or be unexported

stormcat24 · 2017-03-28T10:37:36Z

metrics/metrics.go

+
+type Registry metrics.Registry
+
+func New(metricsType string) (Metrics, error) {


[golint]

[golint] exported function New should have comment or be unexported

stormcat24 · 2017-03-28T10:37:36Z

metrics/metrics.go

+	return m, nil
+}
+
+func GetRegistry() metrics.Registry {


[golint]

[golint] exported function GetRegistry should have comment or be unexported

stormcat24 · 2017-03-28T10:37:36Z

metrics/metrics.go

+	return strings.Join(append([]string{m.Type}, names...), ":")
+}
+
+func (m *Metrics) IncClientCount() {


[golint]

[golint] exported method Metrics.IncClientCount should have comment or be unexported

stormcat24 · 2017-03-28T10:37:36Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(name, m.registry).Inc(int64(1))
+}
+
+func (m *Metrics) DecClientCount() {


[golint]

[golint] exported method Metrics.DecClientCount should have comment or be unexported

stormcat24 · 2017-03-28T10:37:37Z

metrics/metrics.go

+	metrics.GetOrRegisterCounter(name, m.registry).Dec(int64(1))
+}
+
+func (m *Metrics) GetClientCount() int64 {


[golint]

[golint] exported method Metrics.GetClientCount should have comment or be unexported

stormcat24 · 2017-03-28T10:37:37Z

metrics/metrics.go

+	return metrics.GetOrRegisterCounter(name, m.registry).Count()
+}
+
+func (m *Metrics) WriteJSON(w io.Writer) {


[golint]

[golint] exported method Metrics.WriteJSON should have comment or be unexported

stormcat24 · 2017-03-29T06:19:07Z

server/meta.go

+	metrics "github.com/rcrowley/go-metrics"
+)
+
+func NewMetaServer(opt Option) *http.Server {


[golint]

[golint] exported function NewMetaServer should have comment or be unexported

… enabled

stormcat24 · 2017-03-29T09:28:07Z

metrics/http.go

+	"net/http"
+)
+
+func HTTPHandler(w http.ResponseWriter, r *http.Request) {


[golint]

[golint] exported function HTTPHandler should have comment or be unexported

stormcat24 · 2017-03-29T09:28:08Z

metrics/stats.go

+	"time"
+)
+
+type Stats struct {


[golint]

[golint] exported type Stats should have comment or be unexported

stormcat24 · 2017-03-29T09:28:08Z

metrics/stats.go

+	GoVersion    string `json:"go_version"`
+	GoOs         string `json:"go_os"`
+	GoArch       string `json:"go_arch"`
+	CpuNum       int    `json:"cpu_num"`


[golint]

[golint] struct field CpuNum should be CPUNum

stormcat24 · 2017-03-29T09:28:09Z

metrics/stats.go

+	t.Time = tm
+}
+
+var nsInMs float64 = float64(time.Millisecond)


[golint]

[golint] should omit type float64 from declaration of var nsInMs; it will be inferred from the right-hand side

stormcat24 · 2017-03-29T09:28:09Z

metrics/stats.go

+
+// NOTE: The following three variables need to be changed to atomic
+var lastSampleTime safeTime
+var lastPauseNs uint64 = 0


[golint]

[golint] should drop = 0 from declaration of var lastPauseNs; it is the zero value

stormcat24 · 2017-03-29T09:28:10Z

metrics/stats.go

+// NOTE: The following three variables need to be changed to atomic
+var lastSampleTime safeTime
+var lastPauseNs uint64 = 0
+var lastNumGc uint32 = 0


[golint]

[golint] should drop = 0 from declaration of var lastNumGc; it is the zero value

stormcat24 · 2017-03-29T09:28:10Z

metrics/stats.go

+var lastPauseNs uint64 = 0
+var lastNumGc uint32 = 0
+
+var connections int64 = 0


[golint]

[golint] should drop = 0 from declaration of var connections; it is the zero value

stormcat24 · 2017-03-29T09:28:10Z

metrics/stats.go

+
+var connections int64 = 0
+
+func IncConnection() {


[golint]

[golint] exported function IncConnection should have comment or be unexported

stormcat24 · 2017-03-29T09:28:10Z

metrics/stats.go

+	atomic.AddInt64(&connections, 1)
+}
+
+func DecConnection() {


[golint]

[golint] exported function DecConnection should have comment or be unexported

stormcat24 · 2017-03-29T09:28:11Z

metrics/stats.go

+	atomic.AddInt64(&connections, -1)
+}
+
+func GetConnection() int64 {


[golint]

[golint] exported function GetConnection should have comment or be unexported

stormcat24 · 2017-03-29T09:28:11Z

metrics/stats.go

+	return atomic.LoadInt64(&connections)
+}
+
+func GetStats() *Stats {


[golint]

[golint] exported function GetStats should have comment or be unexported

upamune added 2 commits March 28, 2017 16:21

add metrics in sse and grpc

3c9d245

add a metrics file

15305fa

stormcat24 reviewed Mar 28, 2017

View reviewed changes

add metrics server

e2bbfc2

stormcat24 reviewed Mar 28, 2017

View reviewed changes

add metrics response

e573788

stormcat24 reviewed Mar 28, 2017

View reviewed changes

change metrics to registry

abbe726

stormcat24 reviewed Mar 28, 2017

View reviewed changes

upamune added 2 commits March 29, 2017 15:17

merged health check server and metrics server

a7a00b3

delete index.html endpoint

e529b15

stormcat24 reviewed Mar 29, 2017

View reviewed changes

upamune added 3 commits March 29, 2017 15:20

fix to add debugging endpoint only when debug environment variable is…

53819bc

… enabled

update docs

ee46211

add detail metrics

22a4608

stormcat24 reviewed Mar 29, 2017

View reviewed changes

upamune added 2 commits March 29, 2017 18:38

fixed SideCI comments

46a303a

add doc

0a633b0

upamune changed the title ~~[wip] add metrics~~ add metrics Mar 29, 2017

upamune merged commit b4e7285 into master Mar 29, 2017

upamune deleted the feature/metrics branch March 29, 2017 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add metrics #12

add metrics #12

upamune commented Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 28, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017

stormcat24 Mar 29, 2017


		import metrics "github.com/rcrowley/go-metrics"

		type Metrics struct {


		type Registry metrics.Registry

		func New(metricsType string) (Metrics, error) {

add metrics #12

add metrics #12

Conversation

upamune commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment