Set display empty string as default

openfresh · Dec 11, 2017 · 04a4588 · 04a4588
1 parent a9a23be
commit 04a4588
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/index.js b/src/index.js
@@ -31,7 +31,7 @@ export default class ViewportObserver extends React.Component {
 
   static defaultProps = {
     tagName    : 'div',
-    display    : 'block',
+    display    : '',
     onChange   : () => {},
     onEnter    : () => {},
     onLeave    : () => {},
@@ -105,9 +105,11 @@ export default class ViewportObserver extends React.Component {
         props[key] = this.props[key];
       });
 
-    props.style = {
-      display : this.props.display
-    };
+    if (this.props.display !== '') {
+      props.style = {
+        display : this.props.display
+      };
+    }
 
     return React.createElement(this.props.tagName, {
       ...props,

diff --git a/test/index.js b/test/index.js
@@ -19,11 +19,14 @@ describe('ViewportObserver', () => {
     document.body.removeChild(div);
   });
 
-  it('should be rendered as div default', () => {
+  it('should be rendered with default values', () => {
     const component = TestUtils.renderIntoDocument(<ViewportObserver />);
     const node = TestUtils.findRenderedDOMComponentWithTag(component, 'div');
 
     assert.notEqual(node, null);
+
+    assert.equal(node.className, '');
+    assert.equal(node.style.display, '');
   });
 
   it('should be rendered as specified `tagName`', () => {