🐛(back) fix sync_medialive_video command #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
reviewed
Jun 13, 2023
src/backend/marsha/core/management/commands/sync_medialive_video.py
Outdated
Show resolved
Hide resolved
polyhb
force-pushed
the
hbaudesson/fix-sync-medialive-command
branch
from
6514c76
to
f5d1c1f
Compare
lunika
approved these changes
Jun 14, 2023
polyhb
force-pushed
the
hbaudesson/fix-sync-medialive-command
branch
3 times, most recently
from
7c75fdf
to
13b181a
Compare
kernicPanel
approved these changes
Jun 15, 2023
polyhb
force-pushed
the
hbaudesson/fix-sync-medialive-command
branch
from
13b181a
to
6663777
Compare
Split generated by gitfilesplit
Split generated by gitfilesplit
Split generated by gitfilesplit
Split generated by gitfilesplit
Split generated by gitfilesplit
…eate_utils.py', 'split/medialive_utils.py-medialive_utils/medialive_action_utils.py', 'split/medialive_utils.py-medialive_utils/medialive_delete_utils.py' and 'split/medialive_utils.py-medialive_utils/medialive_list_utils.py' into hbaudesson/fix-sync-medialive-command
Remove duplicated code due to medialive_utils.py splitting.
Split test_medialive_utils into test_medialive_delete_utils Split generated by gitfilesplit
Split test_medialive_utils into test_medialive_action_utils Split generated by gitfilesplit
Split test_medialive_utils into test_medialive_create_utils Split generated by gitfilesplit
Split generated by gitfilesplit
…dialive_create_utils.py', 'split/test_medialive_utils.py-medialive_utils/test_medialive_action_utils.py' and 'split/test_medialive_utils.py-medialive_utils/test_medialive_delete_utils.py' into hbaudesson/fix-sync-medialive-command
Remove duplicated code due to test_medialive_utils.py splitting.
The sync_medialive_video is failing when medialive channel exists, but its associated video does not. When a channel does not have a video, it can't be used. Therefore, we should delete the stack of this unused medialive channel.
polyhb
force-pushed
the
hbaudesson/fix-sync-medialive-command
branch
from
6663777
to
1382995
Compare
auto-merge was automatically disabled
June 15, 2023 09:12
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing the #2278, the
sync_medialive_videocommand can sometimes return an errorProposal
The command is failing when the video associated to a medialive channel does not exist. When a channel does not have a video, it can't be used. Therefore, the command should delete the unused medialive channel stack. Stack delete is already implemented so we can reuse it.