Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰(api) allow student to access metadata timedtexttrack's action #234

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

lunika
Copy link
Member

@lunika lunika commented Feb 13, 2019

Purpose

As a student we need to access the OPTIONS endpoint to
retrieve all languages label.

Proposal

  • Change permission class for metadata actions.

@lunika lunika added the bug label Feb 13, 2019
@lunika lunika self-assigned this Feb 13, 2019
@sampaccoud
Copy link
Contributor

@lunika timed text tracks are already available on the document returned by the video detail API endpoint. I think it's enough if what you want is to display the video... If for some reason it is not sufficient then maybe we should remove this information from the video detail endpoint because it takes resources to compute the url signatures...

@lunika
Copy link
Member Author

lunika commented Feb 14, 2019

I will made another PR managing timed text in the video object. I keep this one open because I certainly need the modification about the OPTIONS method.

@lunika lunika changed the title 馃悰(api) allow student to access list and metadata timedtexttrack's action 馃悰(api) allow student to access metadata timedtexttrack's action Feb 14, 2019
@lunika
Copy link
Member Author

lunika commented Feb 14, 2019

@sampaccoud I updated this PR (and also its title and description). I change only the metadata action.

@lunika lunika added improvement and removed bug labels Feb 15, 2019
As a student we need to access the OPTIONS endpoint to
retrieve all languages label.
@lunika lunika merged commit 0800f60 into master Feb 20, 2019
@lunika lunika deleted the student-ttt branch February 20, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants