✨(frontend) replace grommet Heading #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/replace-heading-grommet
branch
4 times, most recently
from
fc321e2
to
480ca92
Compare
kernicPanel
reviewed
Sep 15, 2023
| @@ -44,21 +44,21 @@ const TextBannerBox = styled(Box)` | |||
| `; | |||
|
|
|||
| interface LayoutProps { | |||
| isFullLayout: boolean; | |||
| $isFullLayout: boolean; | |||
There was a problem hiding this comment.
FMI, why adding a $ here ?
There was a problem hiding this comment.
All the props are propagating to the component Heading then the DOM, but we don't want isFullLayout to propagate because it is used only with the styled component HeadingBanner, so to block the propagation you can add a dollar in front of your variable (https://styled-components.com/docs/basics#passed-props).
UploadsView is not used anywhere in the app, so it can be deleted.
In order to do the transition to the cunningham design system, we replace the grommet Heading component with our own Heading component that uses the cunningham design system.
AntoLC
force-pushed
the
feature/anthony/replace-heading-grommet
branch
from
480ca92
to
ebc7e43
Compare
kernicPanel
approved these changes
Sep 18, 2023
lunika
approved these changes
Sep 18, 2023
lunika
added a commit
that referenced
this pull request
Oct 2, 2023
Added - Send an email when a live stream is ready to be converted to VOD - Send an email when a live stream is converted to VOD - Send an email when a live stream is about to be deleted Changed - Replace grommet Heading (#2410) - Upgrade to python 3.11 - Upgrade channels and channels-redis to version 4 Fixed - force bbb user_id uniqueness in join url
lunika
added a commit
that referenced
this pull request
Oct 2, 2023
Added - Send an email when a live stream is ready to be converted to VOD - Send an email when a live stream is converted to VOD - Send an email when a live stream is about to be deleted Changed - Replace grommet Heading (#2410) - Upgrade to python 3.11 - Upgrade channels and channels-redis to version 4 Fixed - force bbb user_id uniqueness in join url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace grommet Heading with a mix of Cunningham and our own wrapper.
Proposal
HeadingwrapperHeadingin the codespaceReview
Extra check here: https://github.com/openfun/marsha/pull/2410/files#diff-338a7653e6c76d240c205006ef794dd9aa28e209ebd7d202042946df64d597e6