Keep only one docker-compose file #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
reviewed
May 2, 2019
jmaupetit
reviewed
May 2, 2019
jmaupetit
approved these changes
May 2, 2019
Having a docker-compose file for tests tasks is useless and hard to maintain. Every time the docker-compose stack change we have to think about updating it. Removing it will ease our work.
Docker-compose configuration for production was not used since a while and for ci we dedied to merge it in the main docker-compose config. We now have only one docker-compose file.
This was referenced May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Having multiple docker-compose files is hard to maintain, every change in the main file should be reflected in other ones. Having only one docker-compose will ease our life.
Proposal
docker/composedirectorydocker-compose.ymlfile to change the environment file to useapp-ciservice