馃殮(config) rename custom configuration files #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaccoud
reviewed
May 21, 2018
config/lms/utils.py
Outdated
| # Load the content of a `settings.yaml` file placed in the current directory if any | ||
| # This file is where customisable settings are stored for a given environment | ||
| # Load the content of a `settings.yml` file placed in the current | ||
| # directory if any This file is where customizable settings are stored |
config/lms/utils.py
Outdated
| # Load the content of a `credentials.vault.yaml` file placed in the current directory if | ||
| # any. This file is where sensitive settings are stored for a given environment | ||
| # Load the content of a `secrets.yml` file placed in the current | ||
| # directory if any. This file is where sensitive settings are stored for |
sampaccoud
approved these changes
May 21, 2018
Expected configurations files names to override settings are now: * `settings.yml` (prev. `settings.yaml`) as the `.yml` extension is more oftlenly used than `.yaml`. * `secrets.yml` (prev. `credentials.vault.yml`) as we try to make the generation of this file independent from ansible (vault).
jmaupetit
force-pushed
the
fix-custom-settings-file-names
branch
from
fc33f63
to
2c4828d
Compare
jmaupetit
added a commit
that referenced
this pull request
May 24, 2018
This patch fixes a bug introduced by my latest PR (see #23). We expect a secrets.yml file.
jmaupetit
added a commit
that referenced
this pull request
May 24, 2018
This patch fixes a bug introduced by my latest PR (see #23). We expect a secrets.yml file.
jmaupetit
added a commit
that referenced
this pull request
May 24, 2018
This patch fixes a bug introduced by my latest PR (see #23). We expect a secrets.yml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to make settings override via YAML files more generic.
Proposal
Expected configurations files names to override settings are now:
settings.yml(prev.settings.yaml) as the.ymlextension is moreoftlenly used than
.yaml.secrets.yml(prev.credentials.vault.yml) as we try to makethe generation of this file independent from ansible (vault).
I've also slightly fixed docstrings/comments formatting (black style) 馃槈